Re: Cannot yank media when image come from Gnome screenshot

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Mon, 05 Aug 2024 17:44:43 +0000, Ihor Radchenko <yantar92@posteo.net> said:

    Ihor> Robert Pluim <rpluim@gmail.com> writes:
    >>>>>>> On Sun, 04 Aug 2024 19:01:24 +0000, Ihor Radchenko <yantar92@posteo.net> said:
    >> 
    Ihor> I am not sure if I like patching Emacs functions when loading Org mode.
    Ihor> On the other hand, I do not see any obvious downside.
    >> 
    >> I was hoping youʼd have a strong opinion 😀

    Ihor> Generally speaking, defining global methods is a very bad practice.
    Ihor> But I feel that it _might_ be justified in this particular case.

Itʼs a specialised global method, so itʼs not too bad

    Ihor> Robert, what do you think about such idea? 
    >> 
    >> Itʼs a cl-defmethod that I assume you will hide behind a version
    >> check, and the changed code itself should only run for a pgtk emacs,
    >> so I donʼt see a great risk. And in the absolute worst case
    >> `yank-media' doesnʼt work, which is the situation we already have.

    Ihor> Yes, behind version check, pgtk build check, and, ideally, after
    Ihor> checking that such method is not yet defined.

The cl-defmethod itself checks itʼs being run in a pgtk emacs, so not
sure we need more than that.

    Ihor> May you create such a patch against Org mode repository?

This week I am a bit busy, so not before middle of next week at the
earliest.

Robert
--