From: Ihor Radchenko <yantar92@posteo.net>
To: "Sławomir Grochowski" <slawomir.grochowski@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [FR] org-colview.el, add annotation for functions summary-types
Date: Thu, 15 Aug 2024 17:41:12 +0000 [thread overview]
Message-ID: <87wmkh1y6f.fsf@localhost> (raw)
In-Reply-To: <87r0aplmok.fsf@gmail.com>
Sławomir Grochowski <slawomir.grochowski@gmail.com> writes:
> Ihor Radchenko <yantar92@posteo.net> writes:
>
>> Why not applying faces?
>
> Because in case of 'annotation-function':
> https://www.gnu.org/software/emacs/manual/html_node/elisp/Programmed-Completion.html
> "...Unless this function puts own face on the annotation suffix string,
> the completions-annotations face is added by default to that string.
Ok. But please double-check that it is really the case.
>> Looks reasonable.
>> Although, I'd prefer to avoid lambda here and simply make it into a
>> proper function. Just like `org-tags-completion-function'.
>
> And this will be private function in colview.el?
> With name... `org-columns--completion-summary-types-function' ?
Yup. Maybe `org-columns--summary-types-completion-function'.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-08-15 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 17:53 [FR] org-colview.el, add annotation for functions summary-types Sławomir Grochowski
2024-08-10 13:03 ` Ihor Radchenko
2024-08-15 14:35 ` Sławomir Grochowski
2024-08-15 16:48 ` Ihor Radchenko
2024-08-15 17:29 ` Sławomir Grochowski
2024-08-15 17:41 ` Ihor Radchenko [this message]
2024-08-16 11:13 ` Sławomir Grochowski
2024-08-18 9:56 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmkh1y6f.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=slawomir.grochowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).