emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Jack Kamm <jackkamm@gmail.com>
Cc: emacs-orgmode@gnu.org, matt@excalamus.com, jeremiejuste@gmail.com
Subject: Re: [PATCH] Async sessions: Fix prompt removal regression in ob-R
Date: Wed, 02 Oct 2024 17:05:14 +0000	[thread overview]
Message-ID: <87wmiqigfp.fsf@localhost> (raw)
In-Reply-To: <87setrqs4z.fsf@gmail.com>

Jack Kamm <jackkamm@gmail.com> writes:

> Consider the following R block, which prints the occurrences of each
> element in a list, including NAs:
>
> #+begin_src R :session :results output :async
>   table(c("ab","ab","c",NA,NA), useNA='always')
> #+end_src
>
> #+RESULTS:
> :   ab    c <NA> 
> :    2    1    2
>
> Since Org 9.7, it instead prints:
>
> #+RESULTS:
> : ab    c <
> : 2    1    2
> ...
> The best solution I could think of was to define a new buffer-local
> variable, `org-babel-comint-prompt-regexp-override', which could be used
> to override `comint-prompt-regexp' for the purpose of filtering. I
> attach a patch with this solution.

Maybe we can simply override `comint-prompt-regexp' as we do in
ob-shell? The default regexp seems to be too permissive.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2024-10-02 17:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-22 21:45 [PATCH] Async sessions: Fix prompt removal regression in ob-R Jack Kamm
2024-10-02 17:05 ` Ihor Radchenko [this message]
2024-10-15  7:03   ` Jack Kamm
2024-10-19  7:58     ` Ihor Radchenko
2024-10-20  7:01       ` Jack Kamm
2024-10-20  9:34         ` Ihor Radchenko
2024-10-22  3:32           ` Jack Kamm
2024-10-22 17:16             ` Ihor Radchenko
2024-10-28  2:55               ` Jack Kamm
2024-10-28 17:16                 ` Ihor Radchenko
2024-11-02  0:19                   ` Jack Kamm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmiqigfp.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=jackkamm@gmail.com \
    --cc=jeremiejuste@gmail.com \
    --cc=matt@excalamus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).