emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Björn Bidar" <bjorn.bidar@thaodan.de>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Karthik Chikmagalur <karthikchikmagalur@gmail.com>,
	emacs-orgmode@gnu.org
Subject: Re: Link preview generation with new link preview property
Date: Mon, 23 Dec 2024 22:41:48 +0200	[thread overview]
Message-ID: <87wmfqqghf.fsf@> (raw)
In-Reply-To: <87plll5jhp.fsf@localhost> (Ihor Radchenko's message of "Sat, 21 Dec 2024 12:05:38 +0000")

Ihor Radchenko <yantar92@posteo.net> writes:

> Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:
>
>>>> ...
>>>> Considering this, it might be better to just split
>>>> `org-link-preview-file' into two public functions, where the "inside"
>>>> function accepts an image instead of a file.
>>>
>>> Agree.
>>> Would you be interested to create a patch?
>>
>> Ihor, did you write a patch for this already?  I thought I saw something
>> from you but can't locate it now.
>
> No, I did not. (I hope I did not forget 🤦)
>
>> If not, I can submit a patch but it will be a week or so before I can
>> get to it.
>
> Maybe you can work with Bjorn on his patch instead?

Anything is fine for me. Feedback on my last patch would be great.


  reply	other threads:[~2024-12-23 20:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <6755f138.0c0a0220.40388.51fbSMTPIN_ADDED_BROKEN@mx.google.com>
2024-12-13  5:49 ` Link preview generation with new link preview property Karthik Chikmagalur
2024-12-14  0:03   ` Björn Bidar
2024-12-14  7:04     ` Ihor Radchenko
2024-12-17  2:46       ` Björn Bidar
2024-12-17 17:39         ` Ihor Radchenko
2024-12-19 21:55           ` Björn Bidar
2024-12-21 12:03             ` Ihor Radchenko
2024-12-17  3:42       ` Karthik Chikmagalur
2024-12-17 17:40         ` Ihor Radchenko
2024-12-19 23:20           ` Björn Bidar
2024-12-20  0:45           ` Karthik Chikmagalur
2024-12-21 12:05             ` Ihor Radchenko
2024-12-23 20:41               ` Björn Bidar [this message]
2024-12-18  6:21         ` stardiviner
2024-12-18  6:33           ` Karthik Chikmagalur
2024-12-19 23:26             ` Björn Bidar
2024-12-21 12:09               ` Ihor Radchenko
2024-12-08 19:18 Björn Bidar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmfqqghf.fsf@ \
    --to=bjorn.bidar@thaodan.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=karthikchikmagalur@gmail.com \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).