From: David Maus <dmaus@ictsoc.de>
To: John Wiegley <jwiegley@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Re: [PATCH] org-wl: Remove dependency on w3m macro `w3m-anchor'
Date: Thu, 27 May 2010 10:06:38 +0200 [thread overview]
Message-ID: <87vda9py41.wl%dmaus@ictsoc.de> (raw)
In-Reply-To: <m28w76tnvm.fsf@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 766 bytes --]
John Wiegley wrote:
>David Maus <dmaus@ictsoc.ed> writes:
>> Again, forgot to mention: Patch is available on
>David, Can you please explain for me the rationale behind this change?
Sure: The problem is, that `w3m-anchor' is not a function, but a
macro. So it must be present when byte compiling org-w3m.el to be
properly expanded. Declaring it an external function via
`declare-function' shuts up the byte compiler but seems to place a
function call into the byte compiled code that fails in runtime
because `w3m-anchor' isn't a function.
This results in error when using byte compiled Org mode.[1]
HTH
-- David
[1] http://article.gmane.org/gmane.emacs.orgmode/25348
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de
[-- Attachment #1.2: Type: application/pgp-signature, Size: 230 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
prev parent reply other threads:[~2010-05-27 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 14:29 [PATCH] org-wl: Remove dependency on w3m macro `w3m-anchor' David Maus
2010-05-22 14:29 ` [PATCH] * lisp/org-w3m.el: Get text property directly, not using " David Maus
2010-05-22 14:30 ` [PATCH] org-wl: Remove dependency on w3m " David Maus
2010-05-26 20:19 ` John Wiegley
2010-05-26 20:21 ` John Wiegley
2010-05-27 8:06 ` David Maus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vda9py41.wl%dmaus@ictsoc.de \
--to=dmaus@ictsoc.de \
--cc=emacs-orgmode@gnu.org \
--cc=jwiegley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).