From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Danjou Subject: Re: [PATCH 1/2] org-agenda: introduce org-agenda-today and org-agenda-get-day-face Date: Mon, 08 Nov 2010 20:28:23 +0100 Message-ID: <87vd47fwdk.fsf@keller.adm.naquadah.org> References: <1289236987-21552-1-git-send-email-julien@danjou.info> <629899F4-DD71-4710-8492-367FB443A0DB@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from [140.186.70.92] (port=56319 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PFXOL-0005oM-Vb for emacs-orgmode@gnu.org; Mon, 08 Nov 2010 14:28:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFXOH-0007hq-RU for emacs-orgmode@gnu.org; Mon, 08 Nov 2010 14:28:33 -0500 Received: from prometheus.naquadah.org ([212.85.154.174]:34459 helo=mx1.naquadah.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFXOH-0007gp-GP for emacs-orgmode@gnu.org; Mon, 08 Nov 2010 14:28:29 -0500 In-Reply-To: <629899F4-DD71-4710-8492-367FB443A0DB@gmail.com> (Carsten Dominik's message of "Mon, 8 Nov 2010 12:34:09 -0600") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain On Mon, Nov 08 2010, Carsten Dominik wrote: > can you please rename org-agenda-today to org-agenda-today-p? > I think it would make its use clearer. I think you misread the function. I've added org-agenda-today which returns today, and just rewrite org-agenda-todayp to use that one. > Also, couly you please specify in the docstring of org-agenda-day-face- > function how the day is coming in into the user-defined function? As a day > number or a calendar date list? It's a calendar date list. Updated patch attached. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-org-agenda-add-org-agenda-day-face-function.patch >From e59409e447f18d92eca9c8faf271901c437746ff Mon Sep 17 00:00:00 2001 From: Julien Danjou Date: Mon, 8 Nov 2010 18:23:07 +0100 Subject: [PATCH] org-agenda: add org-agenda-day-face-function * lisp/org-agenda.el (org-agenda-day-face-function): New variable. (org-agenda-get-day-face): Use org-agenda-day-face-function. Signed-off-by: Julien Danjou --- lisp/org-agenda.el | 20 +++++++++++++++----- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 98371e6..aba85eb 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -1433,6 +1433,14 @@ determines if it is a foreground or a background color." (string :tag "Color") (sexp :tag "Face")))))) +(defcustom org-agenda-day-face-function nil + "Function called to determine what face should be used to display a day. +The only argument passed to that function is the day in the +calendar date list format. It should returns a face, or nil if it +does not want to specify a face and let the normal rules apply." + :group 'org-agenda-line-format + :type 'function) + (defcustom org-agenda-category-icon-alist nil "Alist of category icon to be displayed in agenda views. @@ -3108,11 +3116,13 @@ no longer in use." (defun org-agenda-get-day-face (date) "Return the face DATE should be displayed with." - (cond ((org-agenda-todayp date) - 'org-agenda-date-today) - ((member (calendar-day-of-week date) org-agenda-weekend-days) - 'org-agenda-date-weekend) - (t 'org-agenda-date))) + (or (and (functionp org-agenda-day-face-function) + (funcall org-agenda-day-face-function date)) + (cond ((org-agenda-todayp date) + 'org-agenda-date-today) + ((member (calendar-day-of-week date) org-agenda-weekend-days) + 'org-agenda-date-weekend) + (t 'org-agenda-date)))) ;;; Agenda timeline -- 1.7.2.3 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 Julien Danjou // =E1=90=B0 http://julien.danjou.info --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --=-=-=--