From: David Maus <dmaus@ictsoc.de>
To: wujun zhou <zwj.echo@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: The org-entry-put add extra space after each invoking [7.5 (release_7.5.260.geb2a)]
Date: Tue, 24 May 2011 21:02:40 +0200 [thread overview]
Message-ID: <87vcwz7whb.wl%dmaus@ictsoc.de> (raw)
In-Reply-To: <BANLkTi=VduWno-z0Rsf+XPMmK5ddywaJiQ@mail.gmail.com>
At Sun, 8 May 2011 23:02:30 +0800,
wujun zhou wrote:
>
> Each time I invoke the org-entry-put, I will get an extra space before
> the value, like this:
> <----before
> :prop: 1
> <----after (org-entry-put pom prop 2)
> :prop: 2
> <----and after invoking servel times:
> :prop: 3
> ----------------
> It's harmless to org-property API, but somewhat annoying.
>
> I think, this is introduced by commit
> 92b603c8920623d9c581e2c58809ad2c73fcd475.
>
> It changed the regex from
>
> (concat "^[ \t]*:" property ":\\(.*\\)") (cdr range) t)
>
> to
>
> (concat "^[ \t]*:" (regexp-quote property) ":[ \t]*\\(\\S-.*\\)"))
>
> Thus, the following
> (goto-char (match-beginning 1))
> will be after instead of before the spaces.
>
> And the
> (and value (insert " " value))
> will add the extra space.
Thanks for the analysis, I just pushed a fix for this problem to
master.
Best,
-- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de
prev parent reply other threads:[~2011-05-24 19:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 15:02 Bug: The org-entry-put add extra space after each invoking [7.5 (release_7.5.260.geb2a)] wujun zhou
2011-05-24 19:02 ` David Maus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcwz7whb.wl%dmaus@ictsoc.de \
--to=dmaus@ictsoc.de \
--cc=emacs-orgmode@gnu.org \
--cc=zwj.echo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).