From: Matt Lundin <mdl@imapmail.org>
To: Bastien <bzg@gnu.org>
Cc: Du Yanning <duyanning@gmail.com>,
emacs-orgmode <emacs-orgmode@gnu.org>,
David Maus <dmaus@ictsoc.de>
Subject: Re: bug with org-mode-hook and text-scale-set
Date: Thu, 12 Apr 2012 13:28:07 -0500 [thread overview]
Message-ID: <87vcl4st3c.fsf@fastmail.fm> (raw)
In-Reply-To: <874nspt2ep.fsf@fastmail.fm> (Matt Lundin's message of "Thu, 12 Apr 2012 10:06:54 -0500")
Matt Lundin <mdl@imapmail.org> writes:
> Bastien <bzg@gnu.org> writes:
>
>> Du Yanning <duyanning@gmail.com> writes:
>>
>>> text-mode-hook and c-mode-hook do NOT have this bug.
>>> and the org-mode-hook of orgmode shipped within emacs 23.3 does NOT
>>> have this bug.
>>
>> This is now fixed, thanks.
>>
>> The problem was that Org relied on `face-remapping-alist' to
>> remap the 'default face to the 'org-default face. Relying on
>> this mechanism produces the error you reported, because the
>> text-scale-set doesn't interact well with remapped faces.
>>
>> I'm now relying on `buffer-face-mode' which seems to be a
>> cleaner approach.
>
> On my machine, this change causes a noticeable lag when typing in
> org-mode buffers. The cursor hesitates for a bit and then lurches
> forward. If I turn off buffer-face-mode the lag disappears. I'm still
> figuring out how to diagnose the problem.
Another question: is it customary for major modes to invoke
buffer-face-mode? I was a bit confused when I first saw "BufFace" in the
mode-line, as I had not explicitly invoked the minor mode. My
understanding was that this was primarily intended as a minor mode for
user-level modifications, not for major modes to rely on (but I may very
well be mistaken).
Best,
Matt
next prev parent reply other threads:[~2012-04-12 18:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 6:49 bug with org-mode-hook and text-scale-set Du Yanning
2012-03-14 5:41 ` David Maus
2012-03-14 7:46 ` Du Yanning
2012-03-29 10:45 ` Bastien
2012-04-12 15:06 ` Matt Lundin
2012-04-12 18:28 ` Matt Lundin [this message]
2012-04-13 5:09 ` Bastien
2012-04-20 13:00 ` Bastien
2012-04-22 0:46 ` Matt Lundin
2012-04-13 5:09 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcl4st3c.fsf@fastmail.fm \
--to=mdl@imapmail.org \
--cc=bzg@gnu.org \
--cc=dmaus@ictsoc.de \
--cc=duyanning@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).