From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Lundin Subject: Re: [PATCH] Let org-agenda-time-grid control if the grid is displayed Date: Mon, 28 May 2012 11:02:39 -0500 Message-ID: <87vcjg47kw.fsf@fastmail.fm> References: <87hav3u9t4.fsf@altern.org> <87zk8vadtp.fsf@fastmail.fm> <87obpbr2h0.fsf@altern.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:52829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZ2PC-00022Q-9y for emacs-orgmode@gnu.org; Mon, 28 May 2012 12:02:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZ2P7-000478-82 for emacs-orgmode@gnu.org; Mon, 28 May 2012 12:02:49 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:46637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZ2P6-00046p-Rf for emacs-orgmode@gnu.org; Mon, 28 May 2012 12:02:45 -0400 In-Reply-To: <87obpbr2h0.fsf@altern.org> (Bastien's message of "Sat, 26 May 2012 06:27:39 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: Christophe Junke , emacs-orgmode@gnu.org Hi Bastien, Bastien writes: > Matt Lundin writes: >> This is a problematic patch. On my machine, it causes duplicate entries >> to show up in the agenda. The reason, I believe, is because >> org-agenda-add-time-grid-maybe takes the list of agenda items and >> returns that list with time-grid stuff added. This patch appends the >> list of agenda items to the list that org-agenda-add-time-grid-maybe >> returns, thus resulting in the duplicates. > > Mhh.. I've been testing too hastily. > > Thanks for reporting this, I reverted the commit. > > Christophe, can you look again and amend your patch if needed? I just discovered that Christophe had posted an updated version of the patch here: http://permalink.gmane.org/gmane.emacs.orgmode/56323 Best, Matt