emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: tftorrey@tftorrey.com (T.F. Torrey)
To: emacs-orgmode@gnu.org
Subject: [PATCH] Fixes org-rmail-follow-link
Date: Wed, 08 Aug 2012 16:00:39 -0600	[thread overview]
Message-ID: <87vcgtxcvs.fsf@lapcat.tftorrey.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

With creating links working in Rmail, now I see that following links
fails with the error "Message not found".

The error comes from the use of the function widen in
org-rmail-follow-link. In an RMAIL buffer, the widen function only
widens to the current message. The function to widen to the entire
buffer is rmail-widen.

The attached patch replaces widen with rmail-widen and also removes the
following two lines (added by Bastien as part of the previous patch re
Rmail), because rmail-widen already displays full headers, so testing
and toggling them on has no effect.

GNU Emacs 24.1.50.1 (i686-pc-linux-gnu, GTK+ Version 3.4.2) of
2012-07-29 on doubah, modified by Debian

Org-mode version 7.8.11 (release_7.8.11-392-g9dae6f-git @ mixed
installation! /usr/local/share/emacs/site-lisp/ and
/home/tftorrey/.emacs.d/src/org-mode/lisp/)

Best to all,
Terry
-- 
T.F. Torrey


[-- Attachment #2: Patch for org-rmail-follow-link --]
[-- Type: text/plain, Size: 465 bytes --]

diff --git a/lisp/org-rmail.el b/lisp/org-rmail.el
index 9148a8e..d28a420 100644
--- a/lisp/org-rmail.el
+++ b/lisp/org-rmail.el
@@ -101,9 +101,7 @@
 	(rmail (if (string= folder "RMAIL") rmail-file-name folder))
 	(setq message-number
 	      (save-restriction
-		(widen)
-		(when (eq rmail-header-style 'normal)
-		  (rmail-toggle-header -1))
+		(rmail-widen)
 		(goto-char (point-max))
 		(if (re-search-backward
 		     (concat "^Message-ID:\\s-+" (regexp-quote

             reply	other threads:[~2012-08-10  5:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-08 22:00 T.F. Torrey [this message]
2012-08-10  8:00 ` [PATCH] Fixes org-rmail-follow-link Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vcgtxcvs.fsf@lapcat.tftorrey.com \
    --to=tftorrey@tftorrey.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).