emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* comment bug
@ 2012-07-30 16:48 Samuel Wales
  2012-07-31 12:00 ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Samuel Wales @ 2012-07-30 16:48 UTC (permalink / raw)
  To: emacs-orgmode

For years we had subtle bugs with commenting and filling.  That got
fixed, but now
comment-start is nil.

Perhaps this is related:

commit 94dd2e52439aba488dbac18bd888efb96ede417c
Author: Nicolas Goaziou <n.goaziou@gmail.com>
Date:   Sun Jul 29 00:05:33 2012 +0200

    Rewrite filling functions

    * lisp/org.el (org-fill-context-prefix): New function.
    (org-fill-paragraph, org-auto-fill-function): Use new function.  Also
    handle comments.
    (org-adaptive-fill-function): Remove function.
    (org-get-local-variables, orgstruct++-mode): Don't store now unused
    adaptive-fill* functions.

Thanks.

Samuel

-- 
The Kafka Pandemic: http://thekafkapandemic.blogspot.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: comment bug
  2012-07-30 16:48 comment bug Samuel Wales
@ 2012-07-31 12:00 ` Nicolas Goaziou
  2012-08-07 22:04   ` Samuel Wales
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2012-07-31 12:00 UTC (permalink / raw)
  To: Samuel Wales; +Cc: emacs-orgmode

Hello,

Samuel Wales <samologist@gmail.com> writes:

> For years we had subtle bugs with commenting and filling.  That got
> fixed, but now
> comment-start is nil.

I just committed a complete implementation of comments, compatible with
`comment-dwim'.  Does it behave as expected?


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: comment bug
  2012-07-31 12:00 ` Nicolas Goaziou
@ 2012-08-07 22:04   ` Samuel Wales
  2012-08-08  9:22     ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Samuel Wales @ 2012-08-07 22:04 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode

On 7/31/12, Nicolas Goaziou <n.goaziou@gmail.com> wrote:
> I just committed a complete implementation of comments, compatible with
> `comment-dwim'.  Does it behave as expected?

comment-dwim works properly.  However, when you use it in the middle
of a list, it
splits the list into two lists.

Thanks.

Samuel

-- 
The Kafka Pandemic: http://thekafkapandemic.blogspot.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: comment bug
  2012-08-07 22:04   ` Samuel Wales
@ 2012-08-08  9:22     ` Nicolas Goaziou
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2012-08-08  9:22 UTC (permalink / raw)
  To: Samuel Wales; +Cc: emacs-orgmode

Hello,

Samuel Wales <samologist@gmail.com> writes:

> comment-dwim works properly.  However, when you use it in the middle
> of a list, it splits the list into two lists.

Indeed. But I don't see any clean way to avoid this.

You can wrap the item with #+begin_comment...#+end_comment, assuming you
choose proper indentation.  But it mean that the commented item will be
inside the previous one.


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-08-08  9:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-30 16:48 comment bug Samuel Wales
2012-07-31 12:00 ` Nicolas Goaziou
2012-08-07 22:04   ` Samuel Wales
2012-08-08  9:22     ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).