emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: Bug:install: cannot stat ‘org-install.elc’
Date: Wed, 03 Oct 2012 18:40:29 +0200	[thread overview]
Message-ID: <87vcerh5ky.fsf@Rainer.invalid> (raw)
In-Reply-To: 87bogjiv6t.fsf@Rainer.invalid

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

Achim Gratz writes:
> One suggestion: I'd introduce an org-install.el that never gets compiled
> and only throws a warning if loaded.  This will also help to defuse old
> copies of org-install that are maybe still present later in load-path.

Here's a patch to that effect:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dummy org-install.el --]
[-- Type: text/x-patch, Size: 2265 bytes --]

From 08b4c62aed7596a4b13d046250af7f8c469a9b1c Mon Sep 17 00:00:00 2001
From: Achim Gratz <Stromeko@Stromeko.DE>
Date: Wed, 3 Oct 2012 18:39:07 +0200
Subject: [PATCH] introduce dummy org-install.el to catch old installations

* lisp/Makefile: Arrange for an uncompiled org-install.el.  This also
  ensures that if there's an old org-install.el in the installation
  directory, it will be replaced and not linger.

* lisp/org-install.el: Provide an empty file that prints a warning
  about an outdated configuration.
---
 lisp/Makefile       |  8 ++++----
 lisp/org-install.el | 13 +++++++++++++
 2 files changed, 17 insertions(+), 4 deletions(-)
 create mode 100644 lisp/org-install.el

diff --git a/lisp/Makefile b/lisp/Makefile
index ef8c625..e2f1768 100644
--- a/lisp/Makefile
+++ b/lisp/Makefile
@@ -7,8 +7,9 @@ endif
 LISPV = org-version.el
 LISPI = org-loaddefs.el
 LISPA = $(LISPV) $(LISPI)
+LISPB = $(LISPA:%el=%elc) org-install.elc
 LISPF = $(filter-out $(LISPA),$(sort $(wildcard *.el)))
-LISPC = $(filter-out $(LISPN:%el=%elc),$(LISPF:%el=%elc))
+LISPC = $(filter-out $(LISPB) $(LISPN:%el=%elc),$(LISPF:%el=%elc))
 _ORGCM_ = dirall single source slint1 slint2
 -include local.mk
 
@@ -65,7 +66,7 @@ $(LISPV):	$(LISPF)
 	@$(MAKE_ORG_VERSION)
 
 $(LISPI):	$(LISPV) $(LISPF)
-	@echo "org-install: $(ORGVERSION) ($(GITVERSION))"
+	@echo "org-loaddefs: $(ORGVERSION) ($(GITVERSION))"
 	@$(RM) $(@)
 	@$(MAKE_ORG_INSTALL)
 
@@ -76,10 +77,9 @@ install:	$(LISPF) compile
 	$(CP) $(LISPC) $(LISPF) $(LISPA) $(DESTDIR)$(lispdir)
 
 cleanauto clean cleanall::
-	$(RM) $(LISPA) $(LISPA:%el=%elc)
+	$(RM) $(LISPA) $(LISPB)
 clean cleanall cleanelc::
 	$(RM) *.elc
-	$(RM) org-install.el # Fix leftover from previous install method
 
 clean-install:
 	if [ -d $(DESTDIR)$(lispdir) ] ; then \
diff --git a/lisp/org-install.el b/lisp/org-install.el
new file mode 100644
index 0000000..a31d8b7
--- /dev/null
+++ b/lisp/org-install.el
@@ -0,0 +1,13 @@
+;;; org-install.el --- autogenerated file, do not edit
+;;
+;;; Code:
+(warn "The file org-install is obsolete.
+Please change your configuration to (require 'org) instead.")
+\f
+(provide 'org-install)
+\f
+;; Local Variables:
+;; no-byte-compile: t
+;; coding: utf-8
+;; End:
+;;; org-install.el ends here
-- 
1.7.12.1


[-- Attachment #3: Type: text/plain, Size: 190 bytes --]



Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

  reply	other threads:[~2012-10-03 16:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-03  8:34 Bug:install: cannot stat ‘org-install.elc’ Ian Barton
2012-10-03  8:51 ` Achim Gratz
2012-10-03 10:24   ` Bastien
2012-10-03 12:42     ` Achim Gratz
2012-10-03 16:40       ` Achim Gratz [this message]
2012-10-04 12:01         ` Nicolas Goaziou
2012-10-04 15:47           ` ASSI
2012-10-05 20:26             ` Nicolas Goaziou
2012-10-06  9:19               ` Achim Gratz
2012-10-06  9:50                 ` Nicolas Goaziou
2012-10-06 10:57                   ` Achim Gratz
2012-10-07 17:20                     ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vcerh5ky.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).