From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [BUG] ob-sql.el: probably an extra paren Date: Thu, 21 Mar 2013 18:31:33 +0100 Message-ID: <87vc8k4q2y.fsf@bzg.ath.cx> References: <16047.1363748067@alphaville> <86vc8mtfcx.fsf@somewhere.org> <87fvzqnpfd.fsf@bzg.ath.cx> <87fvzozx88.fsf@bzg.ath.cx> <87hak4d712.fsf@yagnesh.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:41937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIjKz-00050r-2V for emacs-orgmode@gnu.org; Thu, 21 Mar 2013 13:31:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIjKx-0005o4-JZ for emacs-orgmode@gnu.org; Thu, 21 Mar 2013 13:31:37 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:39029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIjKx-0005nk-Cp for emacs-orgmode@gnu.org; Thu, 21 Mar 2013 13:31:35 -0400 Received: by mail-wi0-f176.google.com with SMTP id hm14so6867509wib.9 for ; Thu, 21 Mar 2013 10:31:34 -0700 (PDT) In-Reply-To: <87hak4d712.fsf@yagnesh.org> (Yagnesh Raghava Yakkala's message of "Fri, 22 Mar 2013 01:58:17 +0900") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Yagnesh Raghava Yakkala Cc: Achim Gratz , emacs-orgmode@gnu.org Hello Yagnesh, Yagnesh Raghava Yakkala writes: > We can use travis-ci for automated tests, I just run tests for org-mode¹ on travis > with emacs-snapshot. Magit has been setup recently to run tests for multiple > emacs versions² (emacs23, emacs24 and snapshot). travis has a facility to send > mails if a test fails. Great! > I see you have org-mode repo on your github account, all we need to do put a > post recieve hook to mirror org-mode repo to github. > > we can adopt magit script³ to org-mode as it won't be synced to emacs > trunk. > > what do you think? I think this would be *fantastic*. I have no time for this at the moment, but anyone willing to help setting this up would be my hero. Really :) This is efficient and not intrusive. To give another argument about why I think a pre-push hook on the developer's side is wrong, imagine this scenario: - developer A pushes a commit, all tests pass - developer B works on latest HEAD assuming all tests pass - he wants to push his commits but the tests fail - he naturally thinks it's a problem with *his* changes - ... but it is not ... - M-x doctor RET This happened for real: recently some tests passed under Emacs <24.3 but failed under Emacs >=24.3. If we had a pre-push hook, I would not even be able to push the fix, I would have to deactive the hook first. Best, -- Bastien