From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Schulte <schulte.eric@gmail.com>
Subject: Re: [PATCH 07/10] Simplify org-babel-execute-src-block
Date: Wed, 03 Apr 2013 07:54:49 -0600
Message-ID: <87vc83y79x.fsf@gmail.com>
References: <1364794944-13826-1-git-send-email-aaronecay@gmail.com>
	<1364794944-13826-8-git-send-email-aaronecay@gmail.com>
	<878v50u3dl.fsf@Rainer.invalid>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:37564)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1UNPQD-0001t6-86
	for emacs-orgmode@gnu.org; Wed, 03 Apr 2013 11:16:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1UNPQ8-0007Y6-35
	for emacs-orgmode@gnu.org; Wed, 03 Apr 2013 11:16:21 -0400
Received: from mail-da0-x230.google.com ([2607:f8b0:400e:c00::230]:49948)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1UNPQ7-0007Xr-Tw
	for emacs-orgmode@gnu.org; Wed, 03 Apr 2013 11:16:16 -0400
Received: by mail-da0-f48.google.com with SMTP id p8so705424dan.7
	for <emacs-orgmode@gnu.org>; Wed, 03 Apr 2013 08:16:15 -0700 (PDT)
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org

Achim Gratz <Stromeko@nexgo.de> writes:

> Aaron Ecay writes:
>> * lisp/ob-core.el (org-babel-execute-src-block): Simplify control flow
>>
>> Avoid potential duplication of org-babel-process-params call.  Also
>> makes the code simpler.
>
> You may be changing semantics here.  I'm not entirely certain if the
> current way of dealing with the the unmerged and merged parameters and
> the info block is necessary, but I'd be wary of such a change.
>

Can you check if this change causes any of the existing tests to fail?

Thanks,

-- 
Eric Schulte
http://cs.unm.edu/~eschulte