From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joost Helberg <joost@snow.nl>
Subject: Re: patch for ob-sql and postgresql for supporting :colnames
Date: Mon, 03 Feb 2014 14:11:40 +0100
Message-ID: <87vbwwfiib.fsf@snow.nl>
References: <87bnzm4ol5.fsf@snow.nl> <87wqiaqulb.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57661)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <joost@snow.nl>) id 1WAJLH-00028x-Rz
	for emacs-orgmode@gnu.org; Mon, 03 Feb 2014 08:13:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <joost@snow.nl>) id 1WAJLC-0006bb-JB
	for emacs-orgmode@gnu.org; Mon, 03 Feb 2014 08:13:39 -0500
Received: from mx.snow.nl ([213.154.248.146]:57564)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <joost@snow.nl>) id 1WAJLC-0006bI-CY
	for emacs-orgmode@gnu.org; Mon, 03 Feb 2014 08:13:34 -0500
In-reply-to: <87wqiaqulb.fsf@gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Eric Schulte <schulte.eric@gmail.com>
Cc: Org-Mode <emacs-orgmode@gnu.org>

Eric,

it's not in org-plus-contrib-20140203. Was it lost somehow (also my fix
for stopping on error is not in)?

regards,

Joost

>>>>> "schulte" == schulte eric <schulte.eric@gmail.com> writes:
 > From: schulte.eric@gmail.com
 > To: joost@snow.nl
 > Cc: emacs-orgmode@gnu.org
 > Subject: Re: [O] patch for ob-sql and postgresql for supporting
 > Date: 08-Jan-14 17:58

 > Applied, thanks.

 > Joost Helberg <joost@snow.nl> writes:

 >> hi,
 >> 
 >> the :colnames header argument is not honoured for postgresql. Hence the
 >> following patch for ob-sql.el. The command-line tool psql supports the
 >> option -t for not displaying column-names. The default behavious is not
 >> changed with this patch.
 >> 
 >> 126,127c126
 >> <                                 "psql --set=\"ON_ERROR_STOP=1\" %s -A -P footer=off -F \"\t\"  -f %s -o %s %s"
 >> <                                   (if colnames-p "" "-t")
 >> ---
 >>> "psql --set=\"ON_ERROR_STOP=1\" -A -P footer=off -F \"\t\"  -f %s -o %s %s"
 >> 
 >> Can anyone suggest to me why this should not be in ob-sql.el? It is
 >> already implemented for the mysql engine (via -N).
 >> 
 >> regards,
 >> 
 >> Joost

 > -- 
 > Eric Schulte
 > https://cs.unm.edu/~eschulte
 > PGP: 0x614CA05D


-- 
Snow B.V.