emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [Bug] org-open-at-point adds file+
@ 2014-03-04  8:48 Daimrod
  2014-03-05 13:22 ` Nicolas Goaziou
  0 siblings, 1 reply; 3+ messages in thread
From: Daimrod @ 2014-03-04  8:48 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

Hello,

I think that since its recent rewrite, `org-open-at-point' adds 'file+'
before the name of the application before trying to find the correct
application.

For example the following link:
#+BEGIN_EXAMPLE
[[docview:foo.pdf]]
#+END_EXAMPLE
won't trigger the `org-docview-open' handler
because the following code:
#+BEGIN_SRC emacs-lisp
(or (let ((app (org-element-property :application context)))
			 (nth 1 (assoc (concat "file" (and app (concat "+" app)))
				       org-link-protocols)))
		       #'org-open-file)
#+END_SRC
adds `file+' and then search in `org-link-protocols'.

-- 
Daimrod/Greg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 835 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Bug] org-open-at-point adds file+
  2014-03-04  8:48 [Bug] org-open-at-point adds file+ Daimrod
@ 2014-03-05 13:22 ` Nicolas Goaziou
  2014-03-05 13:27   ` Daimrod
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2014-03-05 13:22 UTC (permalink / raw)
  To: Daimrod; +Cc: emacs-orgmode

Hello,

Daimrod <daimrod@gmail.com> writes:

> I think that since its recent rewrite, `org-open-at-point' adds 'file+'
> before the name of the application before trying to find the correct
> application.
>
> For example the following link:
>
> #+BEGIN_EXAMPLE
> [[docview:foo.pdf]]
> #+END_EXAMPLE
>
> won't trigger the `org-docview-open' handler

This should be fixed. Thank you for reporting it.


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Bug] org-open-at-point adds file+
  2014-03-05 13:22 ` Nicolas Goaziou
@ 2014-03-05 13:27   ` Daimrod
  0 siblings, 0 replies; 3+ messages in thread
From: Daimrod @ 2014-03-05 13:27 UTC (permalink / raw)
  To: emacs-orgmode

Nicolas Goaziou <n.goaziou@gmail.com> writes:

> Hello,
>
> Daimrod <daimrod@gmail.com> writes:
>
>> I think that since its recent rewrite, `org-open-at-point' adds 'file+'
>> before the name of the application before trying to find the correct
>> application.
>>
>> For example the following link:
>>
>> #+BEGIN_EXAMPLE
>> [[docview:foo.pdf]]
>> #+END_EXAMPLE
>>
>> won't trigger the `org-docview-open' handler
>
> This should be fixed. Thank you for reporting it.

Thanks for the fast reply.

> Regards,

-- 
Daimrod/Greg

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-03-05 13:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-04  8:48 [Bug] org-open-at-point adds file+ Daimrod
2014-03-05 13:22 ` Nicolas Goaziou
2014-03-05 13:27   ` Daimrod

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).