From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Subject: Re: [RFC] Rewrite indentation functions
Date: Sun, 04 May 2014 11:25:27 +0800
Message-ID: <87vbtmb4yg.fsf@ericabrahamsen.net>
References: <87oazjnf55.fsf@gmail.com> <87d2fwhh95.fsf@ericabrahamsen.net>
	<87fvksoctz.fsf@gmail.com> <87oazffgne.fsf@ericabrahamsen.net>
	<8738grw8nn.fsf@ericabrahamsen.net> <87tx97ozhr.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57824)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1Wgn0b-0004dQ-VQ
	for emacs-orgmode@gnu.org; Sat, 03 May 2014 23:22:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1Wgn0P-00033K-9T
	for emacs-orgmode@gnu.org; Sat, 03 May 2014 23:22:33 -0400
Received: from plane.gmane.org ([80.91.229.3]:59274)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1Wgn0P-000338-3M
	for emacs-orgmode@gnu.org; Sat, 03 May 2014 23:22:21 -0400
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1Wgn0M-0007m7-AR
	for emacs-orgmode@gnu.org; Sun, 04 May 2014 05:22:18 +0200
Received: from 111.197.167.19 ([111.197.167.19])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Sun, 04 May 2014 05:22:18 +0200
Received: from eric by 111.197.167.19 with local (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Sun, 04 May 2014 05:22:18 +0200
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Nicolas Goaziou <n.goaziou@gmail.com> writes:

> Hello,
>
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>>> Right now I'm seeing breakage with `org-set-property' -- this only
>>> happens on the indentation patches branch. Adding an EXPORT_AUTHOR
>>> property with that command, value of "asdfadsf", gives me this:
>>>
>>> * Test Heading
>>>   :PROPERTIES:
>>>
>>>   :EXPORT_AUTHOR: asdfasdfnil        nil
>>>
>>> Extra blank nil, spurious "nils", and no :END:
>
> [...]
>
>> Specifically, in this section of `org-indent-line':
>>
>> (when (eq type 'node-property)
>> 	       (let ((column (current-column)))
>> 		 (save-excursion
>> 		   (beginning-of-line)
>> 		   (looking-at org-property-re))
>> 		 (replace-match (concat (match-string 4)
>> 					(format org-property-format
>> 						(match-string 1)
>> 						(match-string 3)))
>> 				t t)
>> 		 (org-move-to-column column)))
>>
>> Those match-string calls toward the end both return "nil", and the
>> "nil"s get inserted directly into the buffer. I tried this with a
>> minimal setup (load-paths only, and a blank Org file) and could
>> reproduce.
>
> Indeed. I attach a replacement for both patch 1 and 2.

Looks good! Nothing else to report so far...