From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Kelling Subject: Re: [PATCH] Make the point visible when jumping to the mark Date: Tue, 20 May 2014 15:25:58 -0700 Message-ID: <87vbt0f5op.fsf@treetowl.lan> References: <874n1aq9y5.fsf@treetowl.lan> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmsV8-0007c7-5O for emacs-orgmode@gnu.org; Tue, 20 May 2014 18:27:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmsV2-0006gA-TX for emacs-orgmode@gnu.org; Tue, 20 May 2014 18:27:14 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:53907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmsV2-0006g3-Jl for emacs-orgmode@gnu.org; Tue, 20 May 2014 18:27:08 -0400 Received: from treetowl.lan (unknown [73.53.70.213]) by mail.messagingengine.com (Postfix) with ESMTPA id A63816801F0 for ; Tue, 20 May 2014 18:27:04 -0400 (EDT) In-Reply-To: <874n1aq9y5.fsf@treetowl.lan> (Ian Kelling's message of "Wed, 30 Apr 2014 21:54:08 -0700") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org > From 9191e4a364e251119cf8b7c72e41f6c0d09583f2 Mon Sep 17 00:00:00 2001 > Message-ID: <87ha5aqa93.fsf@treetowl.lan> > MIME-Version: 1.0 > Content-Type: text/plain > > *lisp/org.el: Advise commands which jump to the mark > --- > > There are several non-org commands that jump to a location and would be > unwieldy if the location remained hidden, (isearch, bookmark-jump, > save-place), but org-mode has code to fix them. In this patch, I > followed their example. > > I have an emacs fsf copyright assignment completed & on file with fsf, I can > send gpg signed copy if you need it. > > - Ian Kelling > > > lisp/org.el | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/lisp/org.el b/lisp/org.el > index 44a4e44..9365059 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -24326,6 +24326,27 @@ To get rid of the restriction, use \\[org-agenda-remove-restriction-lock]." > (outline-invisible-p))) > (org-show-context 'bookmark-jump))) > > +(eval-after-load "simple" > + '(defadvice set-mark-command (after org-make-visible activate) > + "Make the point visible with `org-show-context'." > + (org-mark-jump-unhide))) > + > +(eval-after-load "simple" > + '(defadvice exchange-point-and-mark (after org-make-visible activate) > + "Make the point visible with `org-show-context'." > + (org-mark-jump-unhide))) > + > +(eval-after-load "simple" > + '(defadvice pop-global-mark (after org-make-visible activate) > + "Make the point visible with `org-show-context'." > + (org-mark-jump-unhide))) > + > +(defun org-mark-jump-unhide () > + "Make the point visible with `org-show-context' after jumping to the mark." > + (when (and (derived-mode-p 'org-mode) > + (outline-invisible-p)) > + (org-show-context 'mark-goto))) > + > ;; Make session.el ignore our circular variable > (defvar session-globals-exclude) > (eval-after-load "session" I posted this patch in September. It seems it was forgotten. I posted it again on April 30th, nothing yet. I also have another patch thats been sitting on the list for a few weeks now after having a discussion and a positive response. I'd like to do a git pull and find my patches applied at some point, and I'm wondering if/when that will happen. And is there anything I can do to help? - Ian Kelling