Re: resizing windows from an org buffer, reqest for org-shiftcontrol<cursor>-final-hook

[Aaron Ecay <aaronecay@gmail.com>]

Hi Bradley,

2014ko irailak 16an, Brady Trainor-ek idatzi zuen:
> 
> I have
> 
> (global-set-key (kbd "S-C-<left>") 'shrink-window-horizontally)
> (global-set-key (kbd "S-C-<right>") 'enlarge-window-horizontally)
> (global-set-key (kbd "S-C-<down>") 'shrink-window)
> (global-set-key (kbd "S-C-<up>") 'enlarge-window)
> 
> in my init file, as suggested at 
> http://www.emacswiki.org/emacs-en/WindowResize. However, when I am in an 
> org file, the binding fails.
> 
> I had hoped that (setq org-support-shift-select t) would fix this, but 
> it only seems to want to allow selection.
> 
> A solution might be similar to the one
> 
> ;; quick keys for switching windows
> (windmove-default-keybindings)
> ;; fix windmove in org-mode
> (add-hook 'org-shiftup-final-hook 'windmove-up)
> (add-hook 'org-shiftleft-final-hook 'windmove-left)
> (add-hook 'org-shiftdown-final-hook 'windmove-down)
> (add-hook 'org-shiftright-final-hook 'windmove-right)
> 
> as suggested at http://orgmode.org/manual/Conflicts.html.
> 
> Looking at the code in org.el, it seems org-shiftcontrolup and the like 
> were not so lucky to get such a final-hook. Can this be added? I am 
> currently using package.el org-mode, so I may not immediately get to try 
> it out, but would look forward to adding it to my workflow soon.

Rather than adding a hook to these functions, perhaps we should add
another branch to their conditionals which tries (lookup-key global-map
(this-command-keys)), and calls that function if it exists.  The error
would be raised as before if there is no binding for the key in
global-map.

How’s your elisp?  Would you feel up to trying to create such a patch?

-- 
Aaron Ecay