emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Joost Helberg <joost@snow.nl>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: code blocks with multiple word names create single word result-blocks leading to collisions [8.2.10 (8.2.10-elpaplus @ ~/.emacs.d/elpa/org-plus-contrib-20141013/)]
Date: Wed, 18 Feb 2015 15:05:42 +0100	[thread overview]
Message-ID: <87vbizpb61.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87vbizidmz.fsf@snow.nl> (Joost Helberg's message of "Wed, 18 Feb 2015 13:54:12 +0100")

Hello,

Joost Helberg <joost@snow.nl> writes:

>   noweb-syntax allows blanks in names of code blocks. The result-blocks
>   of these code blocks are named as well, but have everything behind the
>   first word stripped. This leads to result-block collisions in case
>   there are two code blocks starting with the same word.
>
>   Is this intentional? Why doesn't org-mode support sentences for code
>   block names? 
>
>   It boils down to the regexp /org-babel-src-name-w-name-regexp/. It
>   matches a name; the match-string function is used for retrieving this
>   name. The regexp should obviously match the rest of the text too.
>
>   The original ob-core.el uses:
>   ="\\([^ ()\f\t\n\r\v]+\\)"=
>   to match the name. Check the ' ' behind the caret.
>
>   The regexp I tested has the space removed. Hence, it will match the
>   full length name. 
> #+begin_src emacs-lisp
> (setq org-babel-src-name-w-name-regexp
>   (concat org-babel-src-name-regexp
> 	  "\\("
> 	  org-babel-multi-line-header-regexp
> 	  "\\)*"
> 	  "\\([^()\f\t\n\r\v]+\\)"))
> #+end_src
>
>
>   Will this just fix or also break things? Was the blank deliberately
>   added? If all OK, can someone please commit/push it?

Applied. Thank you.


Regards,

-- 
Nicolas Goaziou

      parent reply	other threads:[~2015-02-18 14:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18 12:54 Bug: code blocks with multiple word names create single word result-blocks leading to collisions [8.2.10 (8.2.10-elpaplus @ ~/.emacs.d/elpa/org-plus-contrib-20141013/)] Joost Helberg
2015-02-18 13:06 ` Sebastien Vauban
2015-02-18 13:51   ` Joost Helberg
     [not found]     ` <87twyjiazq.fsf-JFNXyGN8thM@public.gmane.org>
2015-02-18 13:59       ` Sebastien Vauban
2015-02-18 14:05 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbizpb61.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=joost@snow.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).