emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Rasmus <rasmus@gmx.us>
To: moptop99@gmail.com
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: Table alignment [8.2.10 (release_8.2.10 @ /usr/local/src/emacs/lisp/org/)]
Date: Wed, 06 May 2015 16:13:28 +0200	[thread overview]
Message-ID: <87vbg5bxpz.fsf@gmx.us> (raw)
In-Reply-To: <CAN_Dec9BEruLh-i=gPbrRhuZT1FAcUEeBhY5mVpc2jY3S93Cug@mail.gmail.com> (Matt Price's message of "Wed, 6 May 2015 09:26:59 -0400")

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

Matt Price <moptop99@gmail.com> writes:

>> I guess it should, but I don't know the rational for the always-centering
>> of headers. . .  If we imposed that change headlines of tables with no
>> instructions would no longer be centered as they default to the "left"
>> class.  This could be an issue if this is a good default style...
>>
>
> Not use if this belongs in the same thread,  but another potential issue
> with the" left" and "right" classes is a namespace clash with external css
> frameworks which use those classes to assign float values.  I export to
> WordPress using a zurb foundation based css framework,  and my tables were
> all messed up until I figured that out.

I don't know what e.g. zurb foundation means, but perhaps something like
the attached fixes your problem.  It's probably a good idea not to use
generic names like "left" as class names anyway.

—Rasmus

-- 
To err is human. To screw up 10⁶ times per second, you need a computer

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-ox-html-Less-generic-names-for-table-aligns.patch --]
[-- Type: text/x-diff, Size: 2951 bytes --]

From fee51384c0384c2a4ead9b9eead109b941408db7 Mon Sep 17 00:00:00 2001
From: Rasmus <rasmus@gmx.us>
Date: Wed, 6 May 2015 16:08:44 +0200
Subject: [PATCH 2/2] ox-html: Less generic names for table aligns.

* ox-html.el (org-html-style-default):
  (org-html-table-cell, org-html-table): Prefix left, right, center classes.

Reported-by: Matt Price <moptop99@gmail.com>
<http://permalink.gmane.org/gmane.emacs.orgmode/97431>
---
 lisp/ox-html.el | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index 0e69e6a..96e9f92 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -286,9 +286,9 @@ for the JavaScript code in this tag.
             padding: 2px; font-size: 80%; font-weight: normal; }
   .timestamp { color: #bebebe; }
   .timestamp-kwd { color: #5f9ea0; }
-  .right  { margin-left: auto; margin-right: 0px;  text-align: right; }
-  .left   { margin-left: 0px;  margin-right: auto; text-align: left; }
-  .center { margin-left: auto; margin-right: auto; text-align: center; }
+  .org-right  { margin-left: auto; margin-right: 0px;  text-align: right; }
+  .org-left   { margin-left: 0px;  margin-right: auto; text-align: left; }
+  .org-center { margin-left: auto; margin-right: auto; text-align: center; }
   .underline { text-decoration: underline; }
   #postamble p, #preamble p { font-size: 90%; margin: .2em; }
   p.verse { margin-left: 3%; }
@@ -327,12 +327,12 @@ for the JavaScript code in this tag.
   caption.t-above { caption-side: top; }
   caption.t-bottom { caption-side: bottom; }
   td, th { vertical-align:top;  }
-  th.right  { text-align: center;  }
-  th.left   { text-align: center;   }
-  th.center { text-align: center; }
-  td.right  { text-align: right;  }
-  td.left   { text-align: left;   }
-  td.center { text-align: center; }
+  th.org-right  { text-align: center;  }
+  th.org-left   { text-align: center;   }
+  th.org-center { text-align: center; }
+  td.org-right  { text-align: right;  }
+  td.org-left   { text-align: left;   }
+  td.org-center { text-align: center; }
   dt { font-weight: bold; }
   .footpara:nth-child(2) { display: inline; }
   .footpara { display: block; }
@@ -3279,7 +3279,7 @@ channel."
 	  (if (not (plist-get info :html-table-align-individual-fields)) ""
 	    (format (if (and (boundp 'org-html-format-table-no-css)
 			     org-html-format-table-no-css)
-			" align=\"%s\"" " class=\"%s\"")
+			" align=\"%s\"" " class=\"org-%s\"")
 		    (org-export-table-cell-alignment table-cell info)))))
     (when (or (not contents) (string= "" (org-trim contents)))
       (setq contents "&#xa0;"))
@@ -3399,7 +3399,7 @@ contextual information."
 	    (alignspec
 	     (if (and (boundp 'org-html-format-table-no-css)
 		      org-html-format-table-no-css)
-		 "align=\"%s\"" "class=\"%s\""))
+		 "align=\"%s\"" "class=\"org-%s\""))
 	    (table-column-specs
 	     (function
 	      (lambda (table info)
-- 
2.4.0


      parent reply	other threads:[~2015-05-06 14:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04  3:02 Bug: Table alignment [8.2.10 (release_8.2.10 @ /usr/local/src/emacs/lisp/org/)] Jay Belanger
2015-05-06 10:56 ` Rasmus
2015-05-06 13:26   ` Matt Price
2015-05-06 13:49     ` Bug: org-toggle-heading breaks with double colon '::' list items Leo Ufimtsev
2015-05-06 23:18       ` Nicolas Goaziou
2015-05-07 16:44         ` Leo Ufimtsev
2015-05-07 18:55           ` Bug: org-return-indent does not work properly with description lists (i.e ending with double colon) Leo Ufimtsev
2015-05-08  8:12             ` Nicolas Goaziou
2015-05-08 15:15               ` Leo Ufimtsev
2015-05-06 14:13     ` Rasmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbg5bxpz.fsf@gmx.us \
    --to=rasmus@gmx.us \
    --cc=emacs-orgmode@gnu.org \
    --cc=moptop99@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).