From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: A proposed enhancement in entering timestamps Date: Thu, 24 Mar 2016 14:09:06 +0100 Message-ID: <87vb4cyqdp.fsf@nicolasgoaziou.fr> References: <8760wlgw2t.fsf@mbork.pl> <874mc5gvnj.fsf@mbork.pl> <87fuvon48l.fsf@nicolasgoaziou.fr> <87twk4fiob.fsf@mbork.pl> <874mc3ewp4.fsf@nicolasgoaziou.fr> <87pourg252.fsf@mbork.pl> <8737ri1cla.fsf@mbork.pl> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj4ya-0004dk-PS for emacs-orgmode@gnu.org; Thu, 24 Mar 2016 09:07:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aj4yZ-0002UJ-Px for emacs-orgmode@gnu.org; Thu, 24 Mar 2016 09:07:00 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:57572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj4yZ-0002TS-JX for emacs-orgmode@gnu.org; Thu, 24 Mar 2016 09:06:59 -0400 In-Reply-To: <8737ri1cla.fsf@mbork.pl> (Marcin Borkowski's message of "Tue, 22 Mar 2016 21:28:49 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Marcin Borkowski Cc: Org-Mode mailing list Hello, Marcin Borkowski writes: > On 2016-03-18, at 17:51, Marcin Borkowski wrote: > >> I'm now reading org-read-date-analyze to be able to enable US military >> format for hours (e.g., 2100 instead of 21:00). This is potentially >> very useful (at least for me), since I'll be able to enter the hour with >> one hand (colon is on shift-semicolon on my keyboard). Another idea >> would be to enable 21.00 (this notation is sometimes used in Poland). >> Would there be demand for such a feature? > > Hi all, > > and thanks Eric and Sam for positive feedback. I agree that US military format can be interesting. However, I think 21.00 could conflict with European format for dates. > One thing that would tremendously help is tests. I think these > functions are rather fragile, in the sense that it's very easy to break > something (`parse-time-string' is a total mess, for example - it is > "clever", yes, but proving that it actually works seems next to > impossible), so without an extensive test suite I wouldn't touch these > functions. Does anyone have - or can make - a set of valid (in > `org-read-date' sense) strings to make tests first and then modify these > functions? (I could make it myself, but I might forget about some cases - > and there are a lot of them! And it's even nontrivial to test the > coverage, since large part of the `parse-time-string' /logic/ is hidden > in the /variable/ `parse-time-rules', which btw has a 1-line > docstring...) I cannot speak for `parse-time-string', but `org-read-date' already has some tests in `test-org/org-read-date'. You can add more if you want to. Regards, -- Nicolas Goaziou