emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jonas Bernoulli <jonas@bernoul.li>
To: emacs-orgmode@gnu.org
Subject: Re: ox-texinfo: empty line before "* Menu:" is missing
Date: Wed, 06 Apr 2016 20:57:43 +0200	[thread overview]
Message-ID: <87vb3uh8ew.fsf@bernoul.li> (raw)
In-Reply-To: <87wpoahbh4.fsf@bernoul.li>

The related `org-texinfo--build-menu' has a similar issue.  Unlike
`org-texinfo-make-menu' which may end up not inserting a newline
when it should, it may end up removing a newline when it should not.

Given this Org file:

  #+TITLE: Demo2 Manual
  #+TEXINFO_DIR_CATEGORY: Emacs
  #+TEXINFO_DIR_TITLE: Demo2: (demo2).
  #+TEXINFO_DIR_DESC: Demo2.
  
  * chapter ends with subsection
  
  ** section
  
  *** subsection
  
  * chapter ends with section
  
  ** just a section
  
  * another chapter

we end up with an info file containing

  * subsection::
  chapter ends with section

but there should be an empty line between these two lines.

This only happens if the preceeding chapter ends with a subsection.
If that ends with section then everything is good.  There might be
other instances where `org-texinfo--build-menu' removes to much
whitespace.

My suggestion is to remove `org-element-normalize-string' from
`org-texinfo--build-menu'.  Again this change might result in some
insignificant whitespace not being removed and again that is better
than removing significant whitespace.

Without doing this the detailed note listing would look like this:

  — The Detailed Node Listing —
  
  chapter ends with subsection                    # bold
  
  * section::                                     # empty line follows
  
  section                                         # bold
  
  * subsection::                                  # no empty line follows
  chapter ends with section                       # not bold
  
  * just a section:

Ps: In both cases you might find better solutions which not only never
    omit necessary whitespace but also never keep/add unnecessary
    whitespace.  But for me just not removing/not adding necessary
    whitespace would be good enough and I believe that the changes I
    have suggested accomplish that.

  reply	other threads:[~2016-04-06 18:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06 17:51 ox-texinfo: empty line before "* Menu:" is missing Jonas Bernoulli
2016-04-06 18:57 ` Jonas Bernoulli [this message]
2016-04-06 20:29   ` Nicolas Goaziou
2016-04-06 20:28 ` Nicolas Goaziou
2016-04-08  9:47   ` Jonas Bernoulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vb3uh8ew.fsf@bernoul.li \
    --to=jonas@bernoul.li \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).