emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Frederick Giasson <fred@fgiasson.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] expose nrepl's timeout setting in ob-clojure.el
Date: Sun, 10 Apr 2016 10:20:22 +0200	[thread overview]
Message-ID: <87vb3pnad5.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <570521D3.4030009@fgiasson.com> (Frederick Giasson's message of "Wed, 6 Apr 2016 10:48:51 -0400")

Hello,

Thank you for the update.

Frederick Giasson <fred@fgiasson.com> writes:

> +(defcustom org-babel-clojure-sync-nrepl-timeout 10
> +  "Timeout value, in seconds, of a Clojure sync call. 
> +   If the value is nil, timeout is disabled."
> +  :type 'integer
> +  :group 'org-babel)

Some keywords are missing:

  :version "25.1"
  :package-version '(Org . "9.0")

and perhaps

  :safe #'wholenump

>  (defcustom org-babel-clojure-backend
>    (cond ((featurep 'cider) 'cider)
>  	(t 'slime))
> @@ -94,8 +100,9 @@
>         (let ((result-params (cdr (assoc :result-params params))))
>  	 (setq result
>  	       (nrepl-dict-get
> -		(nrepl-sync-request:eval
> -		 expanded (cider-current-connection) (cider-current-session))
> +		(let ((nrepl-sync-request-timeout org-babel-clojure-sync-nrepl-timeout))
> +		  (nrepl-sync-request:eval
> +		   expanded (cider-current-connection) (cider-current-session)))

You forgot to

(defvar nrepl-sync-request-timeout)

I also think it makes sense to merge the 3 patches.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2016-04-10  8:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-29 17:38 [PATCH] expose nrepl's timeout setting in ob-clojure.el Frederick Giasson
2016-04-06  9:43 ` Nicolas Goaziou
2016-04-06 14:48   ` Frederick Giasson
2016-04-10  8:20     ` Nicolas Goaziou [this message]
2016-04-11 14:03       ` Frederick Giasson
2016-04-12 20:18         ` Nicolas Goaziou
2016-04-13 20:15           ` Frederick Giasson
2016-04-06 16:27   ` [PATCH] new :async feature for org-babel-clojure Frederick Giasson
2016-04-20 12:17     ` Frederick Giasson
2016-04-20 21:59       ` Nicolas Goaziou
2016-04-21 12:34         ` Frederick Giasson
2016-04-26 19:21           ` Nicolas Goaziou
2016-04-27 12:00             ` Frederick Giasson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vb3pnad5.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=fred@fgiasson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).