From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] ob-sql.el: Support sqlcmd and cygwin environment
Date: Tue, 14 Jun 2016 13:52:32 +0200
Message-ID: <87vb1c0yyn.fsf@saiph.selenimh>
References: <CANO68EOquCbO1EXUcDWA5O5pDVneL3r4G58q9shhG3ww7_sY3Q@mail.gmail.com>
	<87r3c4em1r.fsf@saiph.selenimh>
	<CANO68EO32+Be=gV4JdJ1usSue0yX3V4o4_tL79DYQjX0Bivccg@mail.gmail.com>
	<87a8isdso8.fsf@saiph.selenimh>
	<CANO68EN_USJx1qcGkXUMgPKo2ucOUxkdURy8vZKiPvJDD-2FnA@mail.gmail.com>
	<CANO68EOwu6KDkJbtSVT+u_7MK4VzsChSaq0dq0o9crKk-Fa6AA@mail.gmail.com>
	<CANO68EM9u0SpoCgUkTuToRZX0ON7OF61b9Vinvv36fRTSOq2jw@mail.gmail.com>
	<CANO68EMhW7Og_ejsHrNhAPntC-6bKLWV_zYF4ANbJz6pzGteAw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1bCmtf-0007RP-Lh
	for Emacs-orgmode@gnu.org; Tue, 14 Jun 2016 07:52:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1bCmtd-0005lI-Pc
	for Emacs-orgmode@gnu.org; Tue, 14 Jun 2016 07:52:42 -0400
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:36425)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1bCmtd-0005l9-JK
	for Emacs-orgmode@gnu.org; Tue, 14 Jun 2016 07:52:41 -0400
In-Reply-To: <CANO68EMhW7Og_ejsHrNhAPntC-6bKLWV_zYF4ANbJz6pzGteAw@mail.gmail.com>
	(Xi Shen's message of "Mon, 13 Jun 2016 06:30:32 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Xi Shen <davidshen84@gmail.com>
Cc: "Emacs-orgmode@gnu.org" <Emacs-orgmode@gnu.org>

Hello,

Xi Shen <davidshen84@gmail.com> writes:

> I think I uploaded the wrong patch. Sorry~ Please check this one.

It looks good. Thank you. I have one minor comment about it, see below.

Also, could you provide an entry for ORG-NEWS since this is a user
visible change?

> +(defun org-babel-sql-convert-standard-filename (file)
> +  "Convert the file name to OS standard.
> +In Cygwin environment, is uses Cygwin specific function to
> +convert the file name and double quote it. Otherwise, uses Emacs
> +standard conversion function."
> +  (if (fboundp 'cygwin-convert-file-name-to-windows)
> +      (format "\"%s\"" (cygwin-convert-file-name-to-windows file))
> +    (convert-standard-filename file)))

`cygwin-convert-file-name-to-windows' is going to generate a compilation
warning. You need to declare it with `declare-function' at the top of
the file.

I'm also surprised that the function above doesn't return a string
already. Are you sure the `format' part is needed?

Regards,

-- 
Nicolas Goaziou