From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [Patch] Fix handling of variable capture location
Date: Fri, 19 May 2017 16:16:51 +0200
Message-ID: <87vaoxorsc.fsf@nicolasgoaziou.fr>
References: <CAC38U-ezfZ0REh_7Rjmu3fcqWJEWV7kiM8WtdYY4-fDDC8_XZg@mail.gmail.com>
	<87r2znr7pn.fsf@nicolasgoaziou.fr>
	<CAC38U-eUyrXCwesAfduEV6n81XvtksVMkv-S1FQygTVJ6Mjh2w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40185)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dBii8-0004YH-Lq
	for emacs-orgmode@gnu.org; Fri, 19 May 2017 10:16:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dBii7-0007if-OB
	for emacs-orgmode@gnu.org; Fri, 19 May 2017 10:16:56 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:38155)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dBii7-0007iA-HC
	for emacs-orgmode@gnu.org; Fri, 19 May 2017 10:16:55 -0400
In-Reply-To: <CAC38U-eUyrXCwesAfduEV6n81XvtksVMkv-S1FQygTVJ6Mjh2w@mail.gmail.com>
	(Yuri Lensky's message of "Wed, 17 May 2017 11:52:21 -0700")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Yuri Lensky <ydl@ydl.cm>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

Hello,

Yuri Lensky <ydl@ydl.cm> writes:

> The second call is indeed needed. 

AFAICT, it isn't. 

  (cond ('foo) (t nil)) => 'foo

> This is the case fixed by the patch:
>
> (setq org-default-notes-file (expand-file-name "~/docs/notes.org"))
> (setq org-capture-templates '(("t" "Todo" entry (file+olp
> org-default-notes-file "Inbox") "* TODO %?\n%i")))

OK, I see. I introduced this regression in
88a3c2483ee47b342e9bb7d2c1645dce11179bf5.

I applied your patch with a slight change:

  ((and (symbolp file) (boundp file) (symbol-value file)) (symbol-value file))

=>

  ((and (symbolp file) (boundp file)) (symbol-value file))

Thank you.

Regards,

-- 
Nicolas Goaziou