From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Yuri Lensky <ydl@ydl.cm>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [Patch] Fix handling of variable capture location
Date: Fri, 19 May 2017 16:16:51 +0200 [thread overview]
Message-ID: <87vaoxorsc.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAC38U-eUyrXCwesAfduEV6n81XvtksVMkv-S1FQygTVJ6Mjh2w@mail.gmail.com> (Yuri Lensky's message of "Wed, 17 May 2017 11:52:21 -0700")
Hello,
Yuri Lensky <ydl@ydl.cm> writes:
> The second call is indeed needed.
AFAICT, it isn't.
(cond ('foo) (t nil)) => 'foo
> This is the case fixed by the patch:
>
> (setq org-default-notes-file (expand-file-name "~/docs/notes.org"))
> (setq org-capture-templates '(("t" "Todo" entry (file+olp
> org-default-notes-file "Inbox") "* TODO %?\n%i")))
OK, I see. I introduced this regression in
88a3c2483ee47b342e9bb7d2c1645dce11179bf5.
I applied your patch with a slight change:
((and (symbolp file) (boundp file) (symbol-value file)) (symbol-value file))
=>
((and (symbolp file) (boundp file)) (symbol-value file))
Thank you.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-05-19 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 0:57 [Patch] Fix handling of variable capture location Yuri Lensky
2017-05-17 12:25 ` Nicolas Goaziou
2017-05-17 18:52 ` Yuri Lensky
2017-05-19 14:16 ` Nicolas Goaziou [this message]
2017-05-19 23:37 ` Yuri Lensky
2017-05-20 6:36 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vaoxorsc.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=ydl@ydl.cm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).