From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Mark A. Hershberger" <mah@everybody.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: ox-odt.el should support text:start-value [9.1.14 (9.1.14-7-g01c419-elpaplus @ …/org-plus-contrib-20181015/)]
Date: Fri, 19 Oct 2018 00:19:26 +0200 [thread overview]
Message-ID: <87va5y6gpd.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87r2gom1qx.fsf@everybody.org> (Mark A. Hershberger's message of "Wed, 17 Oct 2018 22:23:34 -0400")
Hello,
"Mark A. Hershberger" <mah@everybody.org> writes:
> Working code changes:
>
> diff -ub org-plus-contrib-20181008/ox-odt.el\~ org-plus-contrib-20181008/ox-odt.el
> --- org-plus-contrib-20181008/ox-odt.el~ 2018-10-12 19:13:13.095335320 -0400
> +++ org-plus-contrib-20181008/ox-odt.el 2018-10-17 22:10:30.194483160 -0400
> @@ -1966,10 +1966,13 @@
> CONTENTS holds the contents of the item. INFO is a plist holding
> contextual information."
> (let* ((plain-list (org-export-get-parent item))
> + (count (org-element-property :counter item))
> (type (org-element-property :type plain-list)))
> (unless (memq type '(ordered unordered descriptive-1 descriptive-2))
> (error "Unknown list type: %S" type))
> - (format "\n<text:list-item>\n%s\n%s"
> + (format (concat "\n<text:list-item"
> + (when count (concat (format " text:start-value=\"%s\"" count)))
> + ">\n%s\n%s")
> contents
> (if (org-element-map item 'table #'identity info 'first-match)
> "</text:list-header>"
Thank you.
Could you provide a patch using git format-patch, with a proper commit
message? Also, if you haven't signed FSF papers, please add TINYCHANGE
at the end of the commit message.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2018-10-18 22:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 2:23 Bug: ox-odt.el should support text:start-value [9.1.14 (9.1.14-7-g01c419-elpaplus @ …/org-plus-contrib-20181015/)] Mark A. Hershberger
2018-10-18 22:19 ` Nicolas Goaziou [this message]
2018-10-19 13:45 ` Mark A. Hershberger
2018-10-20 8:13 ` Nicolas Goaziou
-- strict thread matches above, loose matches on Subject: below --
2018-10-18 1:21 Mark A. Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va5y6gpd.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=mah@everybody.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).