From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: Bernt Hansen <bernt@norang.ca>,
Marco Wahl <marcowahlsoft@gmail.com>,
emacs-org list <emacs-orgmode@gnu.org>,
Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: M-S-RET doesn't work anymore?
Date: Thu, 24 Jan 2019 20:47:14 +0100 [thread overview]
Message-ID: <87va2dyh19.fsf@gmail.com> (raw)
In-Reply-To: <CAFyQvY2tNzhnuHr_=YgWwqXkXVbMQB0VHpZ3xVUa+toJSDkGtQ@mail.gmail.com> (Kaushal Modi's message of "Wed, 23 Jan 2019 16:04:24 -0500")
Kaushal Modi <kaushal.modi@gmail.com> writes:
> On Wed, Jan 23, 2019 at 3:54 PM Marco Wahl <marcowahlsoft@gmail.com> wrote:
>
> As a workaround you can evaluate the lines (that were active before the
> commit)
>
> (org-defkey org-mode-map (kbd "S-<return>") #'org-table-copy-down)
> (org-defkey org-mode-map (kbd "M-S-<return>") #'org-insert-todo-heading)
> (org-defkey org-mode-map (kbd "ESC S-<return>") #'org-insert-todo-heading)
>
> or put them into your init file AFAICS.
>
> Yep, that commit broke the -<return> bindings for me too. I'll have to do the same.
>
> Copying Kevin who originally requested the change of these bindings (this switching of bindings between RET and <return> feels like dejavu to me .. I have seen this done before in Org repo).
>
> Is this a reliable fix to add these lines to the source code again?
> To be honest I don't see clearly.
>
> May be those keys should be bound to both RET and <return> variants?
>
> For Emacs GUI, I think that the <return> variant is needed, RET does nothing.
Gah! Apologies for the breakage. I assumed that in GUI frames, since
<return> is translated to RET when the former is not bound
explicitly[1], *modifier*-<return> would also be translated to
*modifier*-RET, but that does not seem to be the case[2].
My previous experience with M-RET in markdown-mode[3] led me to assume I
could suggest this change without breaking anything… Next time I'll
know better and write those unit tests :)
Thank you for catching this and again, sorry for the disruption.
[1]: In fundamental-mode:
C-h k <return>
⇒ RET (translated from <return>) runs the command newline…
[2]: In fundamental-mode:
M-: (global-set-key (kbd "S-RET") (lambda () (interactive) (message "foo")))
C-h k S-<return>
⇒ RET (translated from <S-return>) runs the command newline…
M-: (global-set-key (kbd "M-S-RET") (lambda () (interactive) (message "bar")))
C-h M-S-<return>
⇒ <M-S-return> is undefined
M-: (global-set-key (kbd "M-RET") (lambda () (interactive) (message "baz")))
C-h M-<return>
⇒ M-RET (translated from <M-return>) runs the command (lambda…)
[3]: https://github.com/jrblevin/markdown-mode/commit/c0fc52461e845baa3c55d9b6f9e67c451a9ffa8d
next prev parent reply other threads:[~2019-01-24 19:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 19:56 M-S-RET doesn't work anymore? Bernt Hansen
2019-01-23 20:44 ` Kaushal Modi
2019-01-23 20:50 ` Marco Wahl
2019-01-23 21:04 ` Kaushal Modi
2019-01-24 13:19 ` Nicolas Goaziou
2019-01-24 14:27 ` Bernt Hansen
2019-01-24 19:47 ` Kévin Le Gouguec [this message]
2019-01-24 0:37 ` Amin Bandali
2019-01-24 1:43 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va2dyh19.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
--cc=kaushal.modi@gmail.com \
--cc=mail@nicolasgoaziou.fr \
--cc=marcowahlsoft@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).