From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthew Lundin <mdl@imapmail.org>
Subject: Re: [BUG] Infinite loop in org-agenda-show-new-time
Date: Wed, 05 Feb 2020 13:50:43 -0600
Message-ID: <87v9okolt8.fsf@fastmail.fm>
References: <87zjswb0vq.fsf@fastmail.fm> <87siyojc2c.fsf@gmail.com>
 <87fvun6gku.fsf@fastmail.fm> <87ob9bkd4c.fsf@gmail.com>
 <87txj2lo0j.fsf@fastmail.fm> <87mwopinzv.fsf@gmail.com>
 <87fvucuwva.fsf@fastmail.fm> <87vc38ff84.fsf@gmail.com>
 <3E07FCDB-2619-4BFE-BC68-C5181717152B@gmail.com> <87haegy5i9.fsf@gmail.com>
 <CAM6wYYJN2-fyMAKjbxynCeEPQFHaiWgmga+VwPd15edPO0MWVA@mail.gmail.com>
 <87blqiodo6.fsf@gnu.org>
 <CAM6wYYJNTwHdvFLPhxuw08RN6vmkDZMSPgLFuH=3L8HetG9tfA@mail.gmail.com>
 <87o8ufo5l8.fsf@gnu.org>
 <CAM6wYYKkbO3ZTTh-6q19LVjx_VRHY2q8WEFuCbs5Cfc6Ek90Uw@mail.gmail.com>
 <87zhdx3otz.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:38157)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mdl@imapmail.org>) id 1izQhf-0006BQ-Dp
 for emacs-orgmode@gnu.org; Wed, 05 Feb 2020 14:51:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mdl@imapmail.org>) id 1izQhe-0003fi-E0
 for emacs-orgmode@gnu.org; Wed, 05 Feb 2020 14:51:15 -0500
In-Reply-To: <87zhdx3otz.fsf@gnu.org>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: Bastien <bzg@gnu.org>, Andrew Hyatt <ahyatt@gmail.com>
Cc: Nick Dokos <ndokos@gmail.com>, "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

Hi Bastien,

Bastien <bzg@gnu.org> writes:
>
> Andrew Hyatt <ahyatt@gmail.com> writes:
>
>> Removing the (beginning-of-line 1) at the end of the time display
>> code in that function, and substituting (org-agenda-previous-line)
>> seems to fix it.=C2=A0 I'm not sure if that's the right approach - the
>> previous code didn't use that function for a reason, but I don't know
>> what that reason was.
>
> I think this approach is correct is it will move over visible lines.
>
> I've pushed a patch, please let me know if it is fixed.

I'm finding that this patch (19676dce758038749887a057208ea33d9a1fad57)
has the by-product of causing multiple paths to flash in the mini-buffer
if org-agenda-show-outline-path is set to t. I believe that is because
it calls org-agenda-previous-line, which in turn calls
org-agenda-do-context-action.

The effect is even more pronounced if org-agenda-follow-mode is on,
causing a significant slowdown in rescheduling items.

Thanks,

Matt