From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aOTLLdf4A1/KTQAA0tVLHw (envelope-from ) for ; Tue, 07 Jul 2020 04:23:51 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id mPl2Kdf4A1+mfwAAbx9fmQ (envelope-from ) for ; Tue, 07 Jul 2020 04:23:51 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A2FCB9408E8 for ; Tue, 7 Jul 2020 04:23:50 +0000 (UTC) Received: from localhost ([::1]:37544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsf91-0007Gq-Pe for larch@yhetil.org; Tue, 07 Jul 2020 00:23:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsf8g-0007B0-16 for emacs-orgmode@gnu.org; Tue, 07 Jul 2020 00:23:26 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:55222) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsf8d-00040d-Od for emacs-orgmode@gnu.org; Tue, 07 Jul 2020 00:23:25 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 5203C6981E; Tue, 7 Jul 2020 00:23:21 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=fQuEyIbgc+qdKpAGpBNtQQ2qtbs=; b=F3zZME NkO9MZYBnedDt55gj09CRCQ5lgRVZeywa8wRcuT2kj94081A8hxr86xPfIPg9HMK QRE4Nh3ojJxFigvoImDtTtpUr413etgVj0piyGgJNLHG12btDHRT7oB4aMwm0+ku lhXMBIZrWqtH1OFEI+Xzv6WK6Iynj3huaPqI8= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 4AD2B6981D; Tue, 7 Jul 2020 00:23:21 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=ZhPmtRaWfiNnO+DV2L+ou8IXpHsPv+F8XcZnm8USxSU=; b=P0MMo0hXcrutr00n4go93qg6FUq8CzcB4K2Gmg68YSDZVHR6s0mqJOn1iIFGREV3fnvdT4QbibBtmZLgXyejbdKSd0KzOdr4vc5ukOyXAy2TWOedmRQjOdH5hhMjHUVhG40Ef0did4rj17IOvrOeMFcvFU2slICwPYzQ87aMZlU= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id B42E66981C; Tue, 7 Jul 2020 00:23:20 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Nick Dokos Subject: Re: [PATCH] org: add property names from #+PROPERTY keywords to completion list In-Reply-To: <87o8osxevq.fsf@alphaville.usersys.redhat.com> References: <87o8osxevq.fsf@alphaville.usersys.redhat.com> Date: Tue, 07 Jul 2020 00:23:09 -0400 Message-ID: <87v9j054ya.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 96EC434C-C009-11EA-A812-C28CBED8090B-24757444!pb-smtp1.pobox.com Received-SPF: pass client-ip=64.147.108.70; envelope-from=kyle@kyleam.com; helo=pb-smtp1.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/07 00:23:21 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=F3zZME N; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=P0MMo0hX; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: /VF/iAu+8SPI Nick Dokos writes: > Here's a patch to enhance the property name completion list with names from > #+PROPERTY keyword lines: at the moment, only property names found in property > drawers are used to populate the completion list. Thanks for the patch. > org: add property names from #+PROPERTY keywords to completion list > > * lisp/org.el (org-buffer-property-keys): ehhance the completion list Typo: enhance. And as a convention nit, it should be capitalized. > with property names from #+PROPERTY keywords, not just property > drawers. > > See https://emacs.stackexchange.com/questions/59448/ for details. > --- > lisp/org.el | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/lisp/org.el b/lisp/org.el > index 748c058ca..0e83162e8 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -13084,6 +13084,11 @@ COLUMN formats in the current buffer." > (props (append > (and specials org-special-properties) > (and defaults (cons org-effort-property org-default-properties)) > + ;; Get property names from #+PROPERTY keywords as well > + (mapcar (lambda (s) > + (let ((split (split-string s))) > + (nth 0 split))) > + (cdar (org-collect-keywords '("PROPERTY")))) > nil))) IMO the let-binding doesn't add any clarity over (nth 0 (split-string s)) I wondered about possible duplicates, but it looks like org-buffer-property-keys already takes care of that at the end. I think this patch is a clear improvement as is, but in the context of completion (and the stack exchange post you link to), isn't the handling around *_ALL keywords still a bit off? It seems a caller would want to complete without the _ALL; to use the example from that post, with "#+PROPERTY: GENRE_ALL ...", the caller would want to complete "GENRE". Is it worth providing special handling here?