From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SE+2L96ODF/zcQAA0tVLHw (envelope-from ) for ; Mon, 13 Jul 2020 16:42:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CCeRK96ODF+aaAAAB5/wlQ (envelope-from ) for ; Mon, 13 Jul 2020 16:42:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 12ED194030A for ; Mon, 13 Jul 2020 16:42:06 +0000 (UTC) Received: from localhost ([::1]:57698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jv1Wm-0004Rg-0D for larch@yhetil.org; Mon, 13 Jul 2020 12:42:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jv1WJ-0004QB-A3 for emacs-orgmode@gnu.org; Mon, 13 Jul 2020 12:41:35 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:37697) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jv1WH-0005Yf-Vg for emacs-orgmode@gnu.org; Mon, 13 Jul 2020 12:41:35 -0400 Received: by mail-qk1-f194.google.com with SMTP id k18so12828207qke.4 for ; Mon, 13 Jul 2020 09:41:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=4h5x3/3iEWROuLvaSTvdLMrcm74zWVkE27m0efUkKxc=; b=QZ+Nsi2qJbIBaePUWN34EMg0XyHiBIOcAg2R99JlYhYrXL59IltIjM0G5n5jDOquDf uqhb+p5fwSv8t8qAf5P6ct2WlEB5YKX1PbMZZpSi67GO+DRi8w+k5zUrRthOFHUcoyJl gedRsiVztNa2JiXEDHMGZpLyGp662dSQdF7e61B+lJ0CXAASbig8U2quw5M6mWsrMn0m Ak72f2ONFnIo6nMfdTFhZL/n62l9OvYI7+j68pZ7a01ESInopJYB+5M/bQLREdu0gFeR USgUmOBaSLd/fkhry0aL5ny84sdw5I41DXvxD5eVvdkxTX7HFtyzpT4uUXNK4bLImHjN vG3A== X-Gm-Message-State: AOAM531amMX/p3ZCi+/LEASMIzGJq1m/2hXLxDlh6NI0100dUXP38CET oB3iy+1KQtQFPyS0alg/viuGxcMv088= X-Google-Smtp-Source: ABdhPJy3ySLo5nRW6O1kkGanUG9uJe7wEQOcaXn5UWefW+ZD/1UIDIoFPqYGloLsHYCCixOfHxVoPw== X-Received: by 2002:a37:7747:: with SMTP id s68mr532640qkc.42.1594658492485; Mon, 13 Jul 2020 09:41:32 -0700 (PDT) Received: from gonk ([2607:f2c0:e360:1126:4182:aadd:5071:e845]) by smtp.gmail.com with ESMTPSA id i21sm21564167qke.9.2020.07.13.09.41.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Jul 2020 09:41:31 -0700 (PDT) From: James N. V. Cash To: Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Make org-eldoc work with Emacs 28 In-Reply-To: <87zh83l66q.fsf@gmail.com> References: <878sfrnxvp.fsf@gmail.com> <87sgdv1j11.fsf@nicolasgoaziou.fr> <87zh83l66q.fsf@gmail.com> Date: Mon, 13 Jul 2020 12:41:31 -0400 Message-ID: <87v9irl64k.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=209.85.222.194; envelope-from=james.nvc@gmail.com; helo=mail-qk1-f194.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/13 12:41:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.59 X-TUID: 1qaAZOO/SBpt Nicolas Goaziou writes: > Do we need another variable for that? Could > org-eldoc-documentation-function catch wrong-number-of-arguments error, > and try another call instead? I believe that the issue is org-eldoc-documentation-function itself is called with the wrong number of arguments; the new behaviour of eldoc-mode is to call the documentation functions with a callback argument, that the documentation function invokes to return its value, unless the strategy is a function. >From the docstring for eldoc-documentation-strategy: > ... > For backward compatibility to the "old" protocol, this variable > can also be set to a function that returns nil or a doc string, > depending whether or not there is documentation to display at > all. Another approach would be to, I suppose, make org-eldoc-documentation-function take an optional callback argument (defaulting to identity) and either wrap the whole body of the function in a funcall of that function or pass the callback to all the functions that org-eldoc-documentation-function calls.