From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YEmlJGSnU1/QVgAA0tVLHw (envelope-from ) for ; Sat, 05 Sep 2020 14:57:40 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IPhxIGSnU1/NawAAB5/wlQ (envelope-from ) for ; Sat, 05 Sep 2020 14:57:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 278929404C7 for ; Sat, 5 Sep 2020 14:57:40 +0000 (UTC) Received: from localhost ([::1]:34364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEZdL-0000Jd-4k for larch@yhetil.org; Sat, 05 Sep 2020 10:57:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEZcr-0000HH-De for emacs-orgmode@gnu.org; Sat, 05 Sep 2020 10:57:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35004) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEZcp-0007ba-Se; Sat, 05 Sep 2020 10:57:07 -0400 Received: from lns-bzn-32-82-254-31-120.adsl.proxad.net ([82.254.31.120]:52364 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1kEZcn-0007qb-Ta; Sat, 05 Sep 2020 10:57:06 -0400 Received: by guerry (Postfix, from userid 1000) id 89A131A60D61; Sat, 5 Sep 2020 16:57:03 +0200 (CEST) From: Bastien To: Vasilij Schneidermann Subject: Re: Bug: [PATCH] org-datetree-insert-line doesn't honor headline spacing customization [9.3 (release_9.3 @ /usr/share/emacs/27.1/lisp/org/)] Organization: GNU References: <20200903085054.GA21638@odonien.localdomain> Date: Sat, 05 Sep 2020 16:57:03 +0200 In-Reply-To: <20200903085054.GA21638@odonien.localdomain> (Vasilij Schneidermann's message of "Thu, 3 Sep 2020 10:50:54 +0200") Message-ID: <87v9gsff0g.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: Fevf2qfaooaE Hi Vasilij, Vasilij Schneidermann writes: > When doing org captures using the datetree format, newly added headlines > do not follow the value of `org-blank-before-new-entry'. This seems to > be the fault of `org-datetree-insert-line' using `insert' as opposed to > `org-insert-heading' to do its work. See the attachment for a proposed > fix. Thanks for the patch. I tried it and these two tests fail: FAILED test-org-datetree/find-date-create FAILED test-org-datetree/find-iso-week-create Perhaps you can check the value of `org-blank-before-new-entry' and insert a blank line only if needed? -- Bastien