From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UOhVF5vPyV9mUQAA0tVLHw (envelope-from ) for ; Fri, 04 Dec 2020 05:56:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6MEVE5vPyV+7HQAAbx9fmQ (envelope-from ) for ; Fri, 04 Dec 2020 05:56:43 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D35B3940430 for ; Fri, 4 Dec 2020 05:56:42 +0000 (UTC) Received: from localhost ([::1]:35454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kl45A-0002P2-2i for larch@yhetil.org; Fri, 04 Dec 2020 00:56:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kl43e-0002OW-S0 for emacs-orgmode@gnu.org; Fri, 04 Dec 2020 00:55:06 -0500 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:41100) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kl43c-0003YH-VE; Fri, 04 Dec 2020 00:55:06 -0500 Received: by mail-pg1-x52f.google.com with SMTP id n10so2860593pgv.8; Thu, 03 Dec 2020 21:55:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:woof-help:date:message-id :mime-version; bh=qxSfOWXo0BTn9ZKYd5F7s45rc7SJAKOywTeHqk6gZRA=; b=a27j6XPA5qbA/o1O2bf3Gw4Fyzi5hQNU82GH/OgKVsYITA0u3zlxW8NwCnEm071ARn FxA2Ze1GpOglY1gc7vnyTyk+8xAnimKCGGrECOWsB02xkBRFIHIGCYqzm+izE23GCN2a GlAaBI4ceUfLRhO5Rf+DF4utnzwxeNJNPOqt1wCJjiA/M/3RqFQUrnvd5SemtcVcjQ+n VNXkyb4fmN53fVQaq8/aELbiWvu8pM+3QMtnv8oEQAGIG+sSdMKl4gi9mOQ2LrKGxaJw YPi7rmBp/gcLqfy9uO0EpeFl3OFVtwr85QB8CIqsjytbDvEZbPEChsUmH0ZinXGeqKW0 6w7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :woof-help:date:message-id:mime-version; bh=qxSfOWXo0BTn9ZKYd5F7s45rc7SJAKOywTeHqk6gZRA=; b=gjTyZCd8WvUlz0/oJDvo5JdYS7ROt4qmP17wn3C+IzUYPH8q93MjRphbWWrDRsq59K Md2k+euNsp4wLNMFE48NI9QJhrl2uw3k8McjQKL+rdwbMUReW/gZ+GmuWZOtF+eAOalM G7QN9EcLxXjI5l/uIar6zMPST0vTAnTnpinCo0EL1Sw/7SmIx541aNApNrEtUgKxGCza 6//Dp/yDbPn0/mSRXW3kGuTLJZ345h+WOOV8UykGyzpp+J9A1B2ntAr+m1P63jyleIP7 aKMnJ4aMWo5bJH/dtb9UEw3zu/dGObtIb3KQ1dv6X6hVaocY3LRT7876JUXFImcHvn0u vuCA== X-Gm-Message-State: AOAM530h5DYjkVIjBePXKTY8dfJcpyw0Lee0rI7PhxR/EpvuLuMSyZur Yp8aubmd+9AySSJEEmo6luk721IDXO8hS4Da X-Google-Smtp-Source: ABdhPJwZqXf5WSScqCxHIUlsS6LVByZ37yrBsLaV4IskhJm3cOCLtjLnzYIXi8z2AjHdy5eq/mKSJA== X-Received: by 2002:a63:ea48:: with SMTP id l8mr1247613pgk.293.1607061302518; Thu, 03 Dec 2020 21:55:02 -0800 (PST) Received: from localhost ([192.200.115.226]) by smtp.gmail.com with ESMTPSA id t36sm3077855pfg.55.2020.12.03.21.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 21:55:01 -0800 (PST) From: Ihor Radchenko To: Kyle Meyer , Nicolas Goaziou , Karl Voit , Christian Heinrich , Bastien Subject: Re: [patch suggestion] Mitigating the poor Emacs performance on huge org files: Do not use overlays for PROPERTY and LOGBOOK drawers In-Reply-To: <87lfh5vvrp.fsf@localhost> References: <87h7x9e5jo.fsf@localhost> <87d07bzvhd.fsf@nicolasgoaziou.fr> <87imh34usq.fsf@localhost> <87pnbby49m.fsf@nicolasgoaziou.fr> <87tv0efvyd.fsf@localhost> <874kse1seu.fsf@localhost> <87r1vhqpja.fsf@nicolasgoaziou.fr> <87tv0d2nk7.fsf@localhost> <87o8qkhy3g.fsf@nicolasgoaziou.fr> <87sgfqu5av.fsf@localhost> <87sgfn6qpc.fsf@nicolasgoaziou.fr> <87367d4ydc.fsf@localhost> <87r1uuotw8.fsf@nicolasgoaziou.fr> <87mu5iq618.fsf@localhost> <87ftb9pqop.fsf@nicolasgoaziou.fr> <875zc2du63.fsf@localhost> <87wo4en8qk.fsf@nicolasgoaziou.fr> <87mu31adeu.fsf@localhost> <871rkcbx40.fsf@kyleam.com> <87mu301in8.fsf@localhost> <87lfh5vvrp.fsf@localhost> Woof-Help: t Date: Fri, 04 Dec 2020 13:58:49 +0800 Message-ID: <87v9di3yee.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=yantar92@gmail.com; helo=mail-pg1-x52f.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.49 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=a27j6XPA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: D35B3940430 X-Spam-Score: -2.49 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: RJEb5cBhk9ey Hello, This is an update about the current status of the patch. Since there was not much feedback, I decided to share the up-to-date branch on github, so that people can directly download/clone the whole thing and load it to Emacs without a need to install the patch manually. The github repo is https://github.com/yantar92/org ---- On the progress with the code, I have found many more bugs, which are not critical for me, but should be fixed anyway. I will keep working on them and keep the github repo up to date. One more important thing I wanted to mention is about the way org-fold should be merged on master. I plan to support using overlays within org-fold depending on custom variable. If the variable is set to 'overlay, org fold will use overlays without all the complexity of text property approach. The 'overlay value will be set by default. If a user wants to use text properties, the variable can be customised. The described approach will allow all the users test the text property-based folding as experimental feature (similar to org-element-use-cache). Once we are confident enough that the code is stable, we can just change the default. What do you think? Best, Ihor Ihor Radchenko writes: > Hello, > >> There are still known problems though. The patch currently breaks many >> org-mode tests when running =make test=. It is partially because some >> tests assume overlays to be used for folding and partially because the >> patch appears to break certain folding conventions. I am still >> investigating this (and learning =ert=). > > All the tests are passing now. > The current version of the patch (against master) is in > https://gist.github.com/yantar92/6447754415457927293acda43a7fcaef > > The patch is stable on my system for last several months. There are > still some minor issues here and there, but it is getting harder for me > to find any problems by myself. I need help from interested users to > review and/or test the patch. > > Best, > Ihor