Re: Bug: Org line commands and visual-line mode bindings [9.3.7 (9.3.7-15-gc9abb4-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200727/)]

[Gustavo Barros <gusbrs.2016@gmail.com>]

Hi Bastien,
Hi Marco,

On Fri, 04 Sep 2020 at 14:37, Bastien <bzg@gnu.org> wrote:

> Hi Gustavo,
>
> Gustavo Barros <gtvbrs@gmail.com> writes:
>
>> I do think my other workaround is worth pondering to be included, so
>> that this would work out-of-the-box.  Do you see any particular
>> drawbacks of setting these bindings directly (that is, not by 
>> remapping)
>> in `org-mode-map'?
>
> You mean by adding something like
>
> (org-defkey org-mode-map (kbd "C-a") #'org-beginning-of-line)
>
> in org-keys.el?  I'm pretty sure such "hard" remapping breaks an Emacs
> convention--I'll ask emacs-devel, because that would indeed fix the
> problem you are reporting.
>
> Thanks for insisting,

I've been playing with 'mwim.el' today, and came up with something that 
might be interesting.

Btw, Bastien, I've seen the message you've sent to emacs-devel about 
this. Thank you. A pity it doesn't seem to have drawn much attention.

Anyway, what I came up is a slight variation from Marco's approach, 
which may be just general enough to be employed by Org.

#+begin_src emacs-lisp
(add-hook 'visual-line-mode-hook #'my/visual-line-mode-hook-for-org)

(defun my/visual-line-mode-hook-for-org ()
  (when (and (derived-mode-p 'org-mode)
             visual-line-mode)
    ;; Ensure 'visual-line-mode' does not shadow Org's line commands.
    (local-set-key [remap move-beginning-of-line] nil)
    (local-set-key [remap move-end-of-line] nil)
    (local-set-key [remap kill-line] nil)))
#+end_src

I've lightly tested this here and it seems to be working.

WDYT?

Best regards,
Gustavo.