From: Timothy <email@example.com> To: Bhavin Gandhi <firstname.lastname@example.org> Cc: email@example.com, firstname.lastname@example.org Subject: Re: Bug: Double trailing slash for default candidate in org-refile-get-target [9.4 (9.4-7-g3eccc5-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200921/)] Date: Mon, 24 May 2021 02:23:27 +0800 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <CAOn=hbe4q7Ym2ApNH5zKd1E3MBNHHY8yr-33mi0xqQEWdnJ+_A@mail.gmail.com> Hi Bhavin! Great to see you on the mailing list :) Thank you so much for looking at the bugs, investigating one, /and/ working out a fix. That's absolutely fantastic of you! For cumulative contributions under 15 (non-trivial) lines from a contributor (such as yourself) we can accept (i.e. merge without FSF papers) the changes and with a "TINYCHANGE" line at the end of the commit message --- but I see you've noticed this and have a nicely formatted commit message, brilliant! Thanks again, and I hope to see you around, Timothy. p.s. For merging hopefully someone like Nicolas or Bastien will be able to take a look at the commit. It looks good to me though :) Bhavin Gandhi <firstname.lastname@example.org> writes: > Finally after spending a couple of hours, I was able to understand the code > of org-refile-get-location \o/. The detailed bug report helped me to > understand the issue. I'm attaching a patch here which should fix the > problem, it has other details as well. I have tested a few basic scenarios > as mentioned in the report. > > OTOH, I haven't signed the FSF Copyright assignment yet, should I do it > before this gets merged or it can be done later?
next prev parent reply other threads:[~2021-05-23 18:24 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-10 18:04 Bhavin Gandhi 2021-05-23 18:05 ` Bhavin Gandhi 2021-05-23 18:23 ` Timothy [this message] 2021-05-23 18:58 ` Gustavo Barros 2021-05-24 16:34 ` Bhavin Gandhi 2021-05-24 16:58 ` Gustavo Barros 2021-05-25 17:52 ` [PATCH] org-refile: Fix double slashes in the refile targets Bhavin Gandhi -- strict thread matches above, loose matches on Subject: below -- 2020-09-21 18:34 Bug: Double trailing slash for default candidate in org-refile-get-target [9.4 (9.4-7-g3eccc5-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200921/)] Gustavo Barros 2020-09-23 14:17 ` stardiviner 2020-09-23 14:49 ` Gustavo Barros 2021-02-14 12:55 ` Gustavo Barros 2021-05-04 6:27 ` Bastien
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Bug: Double trailing slash for default candidate in org-refile-get-target [9.4 (9.4-7-g3eccc5-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200921/)]' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).