From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eEN9CN2GKmH7eQAAgWs5BA (envelope-from ) for ; Sat, 28 Aug 2021 20:56:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sLwlBN2GKmGRPgAA1q6Kng (envelope-from ) for ; Sat, 28 Aug 2021 18:56:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 680341C097 for ; Sat, 28 Aug 2021 20:56:28 +0200 (CEST) Received: from localhost ([::1]:58678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mK3VC-0002Ct-EJ for larch@yhetil.org; Sat, 28 Aug 2021 14:56:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mK3Tz-0002Cg-3U for emacs-orgmode@gnu.org; Sat, 28 Aug 2021 14:55:11 -0400 Received: from forward101j.mail.yandex.net ([2a02:6b8:0:801:2::101]:59608) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mK3Tw-00070v-7b for emacs-orgmode@gnu.org; Sat, 28 Aug 2021 14:55:10 -0400 Received: from myt5-96d8dd611b31.qloud-c.yandex.net (myt5-96d8dd611b31.qloud-c.yandex.net [IPv6:2a02:6b8:c12:5a22:0:640:96d8:dd61]) by forward101j.mail.yandex.net (Yandex) with ESMTP id 12AAE69B62D1; Sat, 28 Aug 2021 21:55:02 +0300 (MSK) Received: from myt5-ca5ec8faf378.qloud-c.yandex.net (myt5-ca5ec8faf378.qloud-c.yandex.net [2a02:6b8:c12:2514:0:640:ca5e:c8fa]) by myt5-96d8dd611b31.qloud-c.yandex.net (mxback/Yandex) with ESMTP id N8l33yGvgD-t1HGeoUs; Sat, 28 Aug 2021 21:55:02 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.com; s=mail; t=1630176902; bh=ijNT9PteCCPzbTkF+JbGaf0dEgboJonEsO+5spXsrxM=; h=In-Reply-To:Subject:Date:References:To:From:Message-ID:Cc:Cc; b=kIEFkA/1Dk2sQe2UdjZSYC7Oy5eSLR70shz/nHqfmwCa7EPLYwr2FV6LITZOApYKN BMceZlHgbr/3cLiGTuZ7GZmMfb4FUa4F/0gUS3DxpZN9rSk4eYVbuot7dN3FkzhIbW lhPS1P9ZeXqIBE9svrmnB7hNvLxXhSHoU28i97es= Received: by myt5-ca5ec8faf378.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id Tq86YvFD7P-t1PufKik; Sat, 28 Aug 2021 21:55:01 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) From: Colin Baxter To: Ihor Radchenko Subject: Re: [PATCH] Re: org-bibtex does not recognise @Comment References: <874kd3288n.fsf@yandex.com> <878s0lu23z.fsf@localhost> <87eead34ol.fsf@yandex.com> <8735qttsi3.fsf@localhost> X-Face: BHjiJOg/Qmj'BQgsAKL@])L)e62P)C"Y=6T Date: Sat, 28 Aug 2021 19:54:59 +0100 In-Reply-To: <8735qttsi3.fsf@localhost> (Ihor Radchenko's message of "Sun, 29 Aug 2021 00:59:32 +0800") Message-ID: <87v93pz9fg.fsf@yandex.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAAEkAAAATAgMAAAChCMjeAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEX/zAABCWP///8I RHjYAAAAAWJLR0QCZgt8ZAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB+UFEAk5BvqS634A AAAbSURBVBjTY2BgCA1hYA0FAxDDgQEERsXoIAYA2F9Eb3cpB+AAAAAldEVYdGRhdGU6Y3JlYXRl ADIwMjEtMDUtMTZUMTA6NTY6MTcrMDE6MDCh/kkpAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTA1 LTE2VDA5OjU3OjA2KzAxOjAwTyZ6HwAAAABJRU5ErkJggg== MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a02:6b8:0:801:2::101; envelope-from=m43cap@yandex.com; helo=forward101j.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630176988; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ijNT9PteCCPzbTkF+JbGaf0dEgboJonEsO+5spXsrxM=; b=Zl4tekKY9Q+lHyF23i4TVaa6EI5zMB7tqP5PaMuw1DNu3pOfE1nsizSmMzVWvymZHL1lv2 DdNfgm3dVXvMALSQGqwWZwYgNM1WISNLGd8iUm3EoroqXI4I78ZegOcJdk+jGYW5lbOBp5 sEFB1BJpA8VTDv5tpTAPamiiGg2IZ4C+XxWFhb0d+9IBZ1xwg7hq9ZYE+rNPh/d5Pp/we6 kNCMI9XBv6yePfIpQf/yjqF2Rm4XU+PPf/e+hcj6CdcX6VCPRTg9SH+zOVK5Gx2504Hpe+ Q4Tv+gkmlrhWaUU1Bx8ROEJY5sp93TzksRpDpabsr62x0DEZsUMX0OlvhFQaDw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630176988; a=rsa-sha256; cv=none; b=A71WWA1J8pSkSbdZuEyGgAksA8p8rNSgFp3eA2DLzEWT3DS3Fy0iarNsTfL9n335KXCz8Z x/BC+eo26dwxz0wBx9icGysNhF4Jexg0NzRE8sEtaTv/AnNFbgf6qhyTm0M92dJFk/l4qF ZbHGjHQgKNgIQp5tChHNtBtNww+FKG1m7KOl30Q5sTNI4hBCwnSXd0GNl53SVrfy6f3GoI lMSsPBhmYB/AJsqOuAPAlRUBaNywWfeFBtPz+iFRi2osR9/1oMdS+0p9U/ECOlZ3AWcT55 qpDhRAffIzPV3I/RJTaV3G/2ZO/0P5Y6vOJdHvAaQ+2teVPwS34h8lcm90fDZQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yandex.com header.s=mail header.b="kIEFkA/1"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yandex.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yandex.com header.s=mail header.b="kIEFkA/1"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yandex.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 680341C097 X-Spam-Score: -1.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4WfGosJCGlr2 >>>>> Ihor Radchenko writes: > Colin Baxter writes: >> > Well. It will import the files. However, org-bibtex-write will >> > indeed fail. If I got it wrong, please provide more details. >> >> > Confirmed >> >> > The fix is attached. >> >> I've applied your patch to my local git branch of org-mode and it >> works very nicely. I can live with the write fail you mentioned. > Let me clarify. On my side, org-bibtex-read-file did not throw any > error on a .bib file with comment. Is it any different for you? Sorry, my first reply was garbled. No there is no difference, org-bibtex-read-file and org-bibtex-import-from-file now do not give any errors for me. Thanks again.