emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Tim Cross <theophilusx@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-toggle-headline inserts "TODO" regardless of local definitions [9.5 (9.5-g0a86ad @ /home/rasmus/.emacs.d/elpa/org-9.5/)]
Date: Mon, 18 Oct 2021 04:53:01 +1100	[thread overview]
Message-ID: <87v91vle4u.fsf@gmail.com> (raw)
In-Reply-To: <875ytvvigc.fsf@localhost>


Ihor Radchenko <yantar92@gmail.com> writes:

> autofrettage <autofrettage@protonmail.ch> writes:
>
>> * DONE Apple
>> ** TODO Banana
>>
>> ...instead of these:
>>
>> * baz Apple
>> ** foo Banana
>
> Confirmed.
>
> Currently, checkbox to todo keyword mapping is hard-coded in
> org-list-to-subtree.
>
> We may use something like
> [ ] -> (car org-not-done-keywords);
> [-] -> (car org-not-done-keywords);
> [X] -> (car org-done-keywords);
>

I would agree hard coded todo keywords is an issue given we allow
people to define the set of todo keywords. I think your suggestion to
use the car of 'org-not-done-keywords and 'org-done-keywords is an
improvement (even if not perfect).

I do wonder if the doc string for org-toggle-heading needs updating. It
makes no reference to making a list item a todo heading if it looks like
a todo item. I was actually surprised that org-toggle-heading adds
keywords at all. While headings and todo items are certainly related, my
expectation would be that a function called org-toggle-heding would do
just that - add stars if none exist and remove them if they do. I would
not necessarily expect a list item to be converted to a todo heading,
only a heading. 


  reply	other threads:[~2021-10-17 18:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-17 14:06 [BUG] org-toggle-headline inserts "TODO" regardless of local definitions [9.5 (9.5-g0a86ad @ /home/rasmus/.emacs.d/elpa/org-9.5/)] autofrettage
2021-10-17 14:23 ` Ihor Radchenko
2021-10-17 17:53   ` Tim Cross [this message]
2022-10-08  4:48     ` Ihor Radchenko
2022-10-08  4:43   ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v91vle4u.fsf@gmail.com \
    --to=theophilusx@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).