Re: [PATCH v2 1/2] lisp/org-clock.el: Make switching states on clock-in/-out easier

["Samuel W. Flint" <swflint@flintfam.org>]

>>>>> Ihor Radchenko writes:

    IR> "Samuel W. Flint" <swflint+orgmode@flintfam.org> writes:
    >> * lisp/org-clock.el (org-clock-in-switch-to-state,
    >> org-clock-out-switch-to-state): Allow
    >> `org-clock-{in,out}-switch-to-state` to be an alist of
    >> current/next-state pairs.
    >> 
    >> (org-clock-in, org-clock-out): Add logic to handle
    >> `org-clock-{in,out}-switch-to-state` as alists.

    IR> Thanks!

    IR> Before we continue, could you please confirm if you have FSF copyright
    IR> assignment? My records show that you have made two commits to Org mode
    IR> previously, and they total LOC is 15, which is maximum allowed
    IR> contribution that does not require copyright assignment. See
    IR> https://orgmode.org/worg/org-contribute.html#copyright

I've sent in the assignment, but I'm waiting on the FSF's response & a
waiver/documentation from my employer.

    >> "Set task to a special todo state while clocking it.
    >> The value should be the state to which the entry should be
    >> -switched.  If the value is a function, it must take one
    >> -parameter (the current TODO state of the item) and return the
    >> -state to switch it to."
    >> +switched.  It may also be an alist of `(CURRENT . NEXT)' pairs.

    IR> Maybe "`(CURRENT . NEXT)' TODO state pairs"? It will be slightly more
    IR> clear.

    >> (defcustom org-clock-out-switch-to-state nil
    >> "Set task to a special todo state after clocking out.
    >> The value should be the state to which the entry should be
    >> -switched.  If the value is a function, it must take one
    >> -parameter (the current TODO state of the item) and return the
    >> -state to switch it to."

    IR> Same here.

I can adjust that as well.  That would definitely clarify the documentation

    IR> The rest looks good.

    IR> If you can, please also add tests.

I'll try my hand at it!

    IR> -- 
    IR> Ihor Radchenko // yantar92,
    IR> Org mode contributor,
    IR> Learn more about Org mode at <https://orgmode.org/>.
    IR> Support Org development at <https://liberapay.com/org-mode>,
    IR> or support my work at <https://liberapay.com/yantar92>

Sam

-- 
Samuel W. Flint
4096R/FA13D704
      (F50D 862B 4F65 5943 A8C2  EF0E 86C9 3E7A FA13 D704)
λs.(s s) λs.(s s)
O< ascii ribbon campaign - stop html mail - www.asciiribbon.org