From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8PlDE1cRa2OVNAAAbAwnHQ (envelope-from ) for ; Wed, 09 Nov 2022 03:32:55 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4HPBElcRa2M7gwAAauVa8A (envelope-from ) for ; Wed, 09 Nov 2022 03:32:55 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E7E183A76F for ; Wed, 9 Nov 2022 03:32:54 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osatC-0004qF-AP; Tue, 08 Nov 2022 21:32:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osatA-0004q3-T6 for emacs-orgmode@gnu.org; Tue, 08 Nov 2022 21:32:29 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osat8-0000U9-T4 for emacs-orgmode@gnu.org; Tue, 08 Nov 2022 21:32:28 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id DBE38240101 for ; Wed, 9 Nov 2022 03:32:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667961144; bh=ZyeQ9DQjqiorJ+Ty9xgGzW7o0qkxljEBio1tSIw5dZY=; h=From:To:Cc:Subject:Date:From; b=KPUwpMFOeq5eSKfZRDEBsXWQcpcYURKJb0JNsgUa4hFuXv7N4dXNluutvkNcFbin9 hxDMxy/llq+01My+TNSw3yIqQJOEmf4RpKT4u06zOEZ1MDoVmLwXIosLr0uO71hfVO YunEXF3Ll5xdJ3SeErUXLSiu+R1LyHtillp4gs+XZtHUn/Gr6Z80ugY6vrljpVzoL+ 39xQo3/kp/xy2GTyBPut9df00F++ZdZU1NrhXoF62hQwAAZVg5Slq45LGUmvZcQoo8 cVmmx3CPrmM064UAB78mvWu+xd4kA1XFjQRFjuJf8wSVpxKDnFqhgzuI2rV0ZrlAbA aUi2Fw0AMUzNw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N6TWq2xtqz9rxF; Wed, 9 Nov 2022 03:32:23 +0100 (CET) From: Ihor Radchenko To: Bruno Barbier Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-babel-insert-result: Fix wrong-type-argument markerp nil In-Reply-To: References: Date: Wed, 09 Nov 2022 02:33:02 +0000 Message-ID: <87v8noc0wx.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667961175; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=C8+R+UreVjOxC6rGBp+ZgSW+QClke/v/J5NpcMq5oJA=; b=I9j9vp/mpP0NlbFx1pyzy5J6wi+2GZ4qO2b+i+4/+C2dpOoj+qDvgb64a16ocZFvvOD1Nn dE4vFdyV8Sj2pGxdq2LOyVYR8/gDbtY73sGbdCPPAkNIzjsQC/uFxlu1NL4FXINtDg6vSb j6QqslPL9yWJf0li+U/NPngcg/vGyLjhLJTXh1wB9b7KtrAI3scFeobaQFv8GpFE/6wC3m 7M9VZhCLSk5NGR4J5NKVDohaXfPuQQM/nzmUJfq9astBScesivRJN9kKKXKwd2cdxVfoyl CD54vLaP0Ag2VFBWZddJpckUN36P5jQY3d3uT+dSORoqMSwVypxljuzzc3r4+w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667961175; a=rsa-sha256; cv=none; b=ZfDlsLEyjjTPdue5stURBio0bN/3/YPeOpv5DtIaivFIFcz8ua6soE73fypUHvnT/FANAH pOIcD2T4jUr2zu9W2zkpMkNL5h+RjwuKdDp/AD6FQrsM6QAkLOATimUjjq99Kl3m2mQne7 Npul5t37Mfcjvut2jXw7/5P5ieee5dlylT4Wyl5jGiIZCAHDi9wTzuxcTeRQ1TNxFDbdg9 3WfpcAqKnqusgWQZoQeAWqRSBX+cM8qVOFeggDB78q063pemY5/OtHjBYI2ZwzMMghaY6H iSg+EeTggzLcm+HJ5ziMqUekiCCJl5nyH77kj1YwYRs/vVfPY1VSViYdNcbl1A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=KPUwpMFO; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.32 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=KPUwpMFO; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E7E183A76F X-Spam-Score: -5.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: GanGVs/tTLx3 Bruno Barbier writes: > Here is a small patch for a corner case in `org-babel-insert-result'. Thanks, but could you please explain a bit more about this corner case? > lisp/ob-core.el (org-babel-insert-result): Don't reset the marker > `end' if it is not defined. `end' must be always defined because (setq end (copy-marker (point) t)) must be executed. Nothing must ever set `end' to nil. Otherwise, a couple of other places in code will also be broken. Your patch, if addressing a valid scenario, is not treating the root cause; just the symptom. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at