From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SGXeBbObEWT2OgAASxT56A (envelope-from ) for ; Wed, 15 Mar 2023 11:19:31 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uC7xBLObEWTyWgAAG6o9tA (envelope-from ) for ; Wed, 15 Mar 2023 11:19:31 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B625F914E for ; Wed, 15 Mar 2023 11:19:30 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=e84mFr1N; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678875570; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=R4wr9Q8OLoalXwgbDJldm00kFOr+CEFv6B2BQX2We9s=; b=RzV7lq0WueBv33yh4h5SZniJBkoeEQVLbVvsbj7MCDwojcWt6nyoK0f1svgnZxbRP0khzp ecw/9eNIEsGEWE39pzhVikJgzYsCCY7QfVCNmWy7bxE++kPuXedrLUVQA+3H/Ov8AzX+0Q QfXOnM+DZ325Ew021iyGYzBgrIM6eH7ZOFOzml5vYQxXClNtUNC6t87eCi2k9ecL5lwvlo Qg1KkFvJeaC9ikui7hEehDPkwsMT7Qhp6/vF6YmukwjvVZ/ql/UJJeT2BlfbLB5V9CM8Us mwL2zJxEjhOi3rChfuIm8TVxQpXUsP2zBsOZSCKy7ewYk/YOMlNWwS7FiAHv1Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=e84mFr1N; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678875570; a=rsa-sha256; cv=none; b=MSL9CwH63+EeMXr0Aoz1qWvqFEkjPDcyIhbrO9uPs/jb1LR2OW/d7bWdoGkXkuj7jNPOzy O8kMNRl9E9InWbcmtn7kV71vVvOkiUuYmrOBGjp7zBlSs1tQwt+MA/jIzB3hmg6kOObze8 0djWof2+VAj4k8tAV+totEqFaT3mH/grVzIedy2iqvitdgmkItzC/Ujmz/6fPFN0UOUO/F M/Za2lYnKlgJyPsA/VkI68hOFHmlepGKOuBnSLrraNMhH6ylty0PMIX2tzbNzxxVMNE+TN XU4pXd9rh0CsyApYTOd7godCSZPusn9jTvM0370gm+8IyPVoEit5CkcNvtWtmw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pcODU-0006kc-2X; Wed, 15 Mar 2023 06:18:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcODP-0006kF-Ck for emacs-orgmode@gnu.org; Wed, 15 Mar 2023 06:18:40 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcODN-0003Ew-7f for emacs-orgmode@gnu.org; Wed, 15 Mar 2023 06:18:39 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 6848C24054F for ; Wed, 15 Mar 2023 11:18:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1678875513; bh=f+FRl72qqSNx9y7+Fm7YaPS9t19KKLeydQww192O0cA=; h=From:To:Cc:Subject:Date:From; b=e84mFr1NY4VN4ys+zW8UmSOMZLJtw5A1ZwTZlr55Gmhffn3zN+y5fEyURf8HDNW2I kfx55bM6BW2XlhYfBy4y8rVxRKTqvRNMSM3DRQ8gznhXrHM4Vv/vqYIQrJFTA6Phmp n1lVI5kb8MTL+7s9JIPg1L4FDX6/SKvv2YuzntV1NTWbe9Izslkg4cimDfUfakRVks b5JjwFNcpqZnVsv0hBzYf9oyv0TZTbK44OChKD8sFMoKbFubee1g4YnMaNHETFmhC7 nzKMxGsQJgpddmiWeo+L+2evvyFRtHUh8jkT3uNPzsMCdmReCCeEDBxC7+y+8VqblX v1phXLFUanNbg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Pc5vV6HLkz9rxH; Wed, 15 Mar 2023 11:18:30 +0100 (CET) From: Ihor Radchenko To: Daniel Kraus Cc: emacs-orgmode@gnu.org Subject: Re: [patch] ob-clojure: Fix results output In-Reply-To: <87y1nzflur.fsf@kraus.my> References: <87mt4m53qj.fsf@kraus.my> <87pm9gyebl.fsf@localhost> <877cvkhh9d.fsf@kraus.my> <874jqno6hw.fsf@localhost> <873567h2kk.fsf@kraus.my> <87y1nzflur.fsf@kraus.my> Date: Wed, 15 Mar 2023 10:20:21 +0000 Message-ID: <87v8j2qpsq.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: B625F914E X-Spam-Score: -11.84 X-Migadu-Spam-Score: -11.84 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: Uh/Ad1pcOSbU Daniel Kraus writes: > Ups, I attached the wrong one. > Here the correct patch.. Thanks! Some more comments ;) > (defcustom org-babel-clojure-backend (cond > ((executable-find "bb") 'babashka) > - ((executable-find "nbb") 'nbb) > + ((executable-find "clojure") 'clojure-cli) > ((featurep 'cider) 'cider) > ((featurep 'inf-clojure) 'inf-clojure) > ((featurep 'slime) 'slime) > (t nil)) What will happen with users who customized `org-babel-clojure-backend' to 'nbb in the past? > +(defcustom org-babel-clojurescript-backend > + (cond > + ((or (executable-find "nbb") (executable-find "npx")) 'nbb) > + ((featurep 'cider) 'cider) > + (t nil)) > + "Backend used to evaluate Clojure code blocks." This docstring is exactly the same with `org-babel-clojure-backend'. What is the difference? I think ""Backend used to evaluate ClojureScript code blocks." will be more clear. I feel that other docstrings may also need to be clarified depending whether they affect Clojure or ClojureScript blocks. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at