From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id MHJzIZuL9WS5aAEAG6o9tA:P1 (envelope-from ) for ; Mon, 04 Sep 2023 09:47:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id MHJzIZuL9WS5aAEAG6o9tA (envelope-from ) for ; Mon, 04 Sep 2023 09:47:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 52FD4605AE for ; Mon, 4 Sep 2023 09:47:39 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=RxrBUF2a; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693813659; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=oCffjxfuKwTaPkcuZ72MDaF1QaFyW3sFuSahaLrRYt4=; b=UqwOWyOOVqqojmvnjSV9kzelff8fL/HZjPxus8TXaKrJEC/OxCspvgCcs31uHdhz4aygMa ablDJiGZkA+E0Eh1mlFN+PyK1gqT4UCcBMF4RpcuK+kjhemqxi+0hnF+hKOrMBQyn/wC3K 6H/YrNCBN4tVNhh9jXRbij0bY6CW/NyGXZKA187hAVjGv1aqJv25P6HBJUigzvedDqN+gY n5AYkB2jUiZQt3Msb59qs6ACZBKSJ+vIRjfQAZyQHeM0xbepoxws39hrkJ+c0NB1vUOeDR v3KaplcG0nr2T6oerDUc/DauilQvY8PZK08Sgeqw6y0QE0Fj5wsVSVj/Z/skzg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693813659; a=rsa-sha256; cv=none; b=XtmqHKCGZtoEwdaB60T0lMh44ewq264Mpi7hy+fvH6TmoPCimJN64d/HJKDXUMYtVGlPtk V5s+PF49W9O1k7jyiYvC256GQLrNYNnFlAvioaxN01TwvpywRoJddm8OXYOQTpiZ0F//R/ MNut3u0PsQ+2otru0Vvmsp19urGQlICUr9l7wTm/tm4fyilEtfpgipejQ2Crwyt039N0v2 w76gJ4uq73ivXYazfHy1xr5smNUEFZSkWfcD9Z5NEeSMzkeRSDMEfL2r657n7FFdwSyPm5 zhkNVew+lnngFVnpnsTCwstls+Kxeuak5zfPqlg1q0KKWMzdgqvsKpQokPuVVQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=RxrBUF2a; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qd4IL-0002p3-Sz; Mon, 04 Sep 2023 03:46:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qd4I0-0002oe-1w for emacs-orgmode@gnu.org; Mon, 04 Sep 2023 03:46:28 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qd4Hx-0001Ko-7K for emacs-orgmode@gnu.org; Mon, 04 Sep 2023 03:46:27 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 69B9C240027 for ; Mon, 4 Sep 2023 09:46:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693813582; bh=TnaZ9wSgCzzUqTFl6rG0CUGX6YOWXYXMrNGPof7hqj4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=RxrBUF2aLnqVbNsNdf/8wpkrojutZUIym40ZQbOt93sqmHF1Du6/mE3/moY9qU09T /g8j35x9MalHohh2T1izGx1Ogbpxn3D0waWhs1nTvyYsF3pe/Ca1MNRm0ghCz6L3CC 40PMCjOA4nVbeuQrQ1iQgO87JdVCVG7AOH68+4Hwjxn8SUR55sHZf2NgKRZH+XnxC9 aK/DXlPvvltjfJCYZLvPfwSkOm2oaaaXMWNWiuuEaK8K91ki08/cwXtG3Kehl2u0Dg aWa1R0uq2sMlZco+aC/xpv12Ll6UTZQo12iUK1eMu2LBh8BuRpcSZA4nEniCwfRVVM B/eO9A4UN8AVg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RfLL56s2Qz6tvn; Mon, 4 Sep 2023 09:46:21 +0200 (CEST) From: Ihor Radchenko To: No Wayman Cc: emacs-orgmode@gnu.org Subject: Re: Org mode version 9.7-pre (9.7-pre-n/a-g63e8ca @ /home/n/.emacs.d/elpaca/builds/org/); [PATCH] refactor org-babel-lilypond-compile-lilyfile In-Reply-To: <87pm2zgiac.fsf@gmail.com> References: <87jztk1rdc.fsf@gmail.com> <878r9zim0z.fsf@localhost> <87pm2zgiac.fsf@gmail.com> Date: Mon, 04 Sep 2023 07:47:03 +0000 Message-ID: <87v8cqwfbc.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -8.55 X-Spam-Score: -8.55 X-Migadu-Queue-Id: 52FD4605AE X-TUID: aHOI1/Qq01/K No Wayman writes: > Ihor Radchenko writes: > >>> - Removes the optional TEST parameter, which is unused and >>> better >>> served through debugging tools. >> >> This is technically a breaking change. So, we (1) need to >> mention it in >> ORG-NEWS; (2) may consider (file-name &optional _) function >> definition >> to be 100% sure that no existing code will be broken. > > I've added the NEWS entry and updated the signature to ignore the > second, optional parameter. > See attached. Thanks! > +*** ~org-babel-lilypond-compile-lilyfile~ ignores optional second argument > + > +The =TEST= parameter is better served by Emacs debugging tools. It looks like ob-lilypond/ly-compile-lilyfile test is relying on this optional second argument. So, after applying your patch, make test is failing. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at