From: Ihor Radchenko <yantar92@posteo.net>
To: Antero Mejr <antero@mailbox.org>, Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Move files when using org-babel-tangle-publish
Date: Sat, 09 Dec 2023 10:29:00 +0000 [thread overview]
Message-ID: <87v897sm8j.fsf@localhost> (raw)
In-Reply-To: <87v898mgx4.fsf@mailbox.org>
Antero Mejr <antero@mailbox.org> writes:
> Ihor Radchenko <yantar92@posteo.net> writes:
>
>> Also, may I know if you have an FSF copyright assignment? If not, you
>> also need to add TINYCHANGE to the commit message - see
>> https://orgmode.org/worg/org-contribute.html#first-patch
>
> Yes I have assigned copyright to the FSF already.
Bastien, may you please confirm?
>> I think that it would be nice to add a brief comment why `rename-file'
>> to the code as well. `copy-file' looks innocent there from a first
>> glance.
>
> Fixed in attached patch.
Thanks!
Applied, onto main, adding a link to this thread in the commit message
and an extra sentence to the comment.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=478576749
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-12-09 10:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 16:30 [PATCH] Move files when using org-babel-tangle-publish Antero Mejr
2023-12-08 21:36 ` Ihor Radchenko
2023-12-08 23:08 ` Antero Mejr
2023-12-09 10:29 ` Ihor Radchenko [this message]
2023-12-09 17:42 ` Bastien Guerry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v897sm8j.fsf@localhost \
--to=yantar92@posteo.net \
--cc=antero@mailbox.org \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).