From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:5f26::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id nLquHEMSiGUFnQAAkFu2QA (envelope-from ) for ; Sun, 24 Dec 2023 12:13:07 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id iJHSGEMSiGVVnAAAqHPOHw (envelope-from ) for ; Sun, 24 Dec 2023 12:13:07 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=SJEufc3m; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1703416387; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jzw++pjBRdsiTclKK38qHnw9CiLJRV6E+4YJuk0v+SI=; b=tXwQf8dA0rHM/GbhuZ5NFApVBP57pyN4Orw4GiJSDSAl1gUakrgF7Z4BUdUHWojb2+IcXQ tfg5soM6OTZ8U760DjQ6uvyrIXBNbtt64jV2H3lL/fcuft/i5BCrqr8kGUs4t9yDW1RIsl i2NvgDU84qzeeDLlQK/oCfksUbLfZdhXbI9ykO38KUWQZh9811j3gqqqY8XDJy3OqjL5TM H8J98kd5bSxxF+jh5oYLCs7TYPL3cx0YhSk1Hf4XYxVdhtHziXwFbLAPIDPggEZB6ulUZN fBnWgn429s9vgeZZ0SBiFT/ogWHAA4Ee3jZFv9bWbjSYoJO5M8JgCcbuxrwTIA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=SJEufc3m; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1703416387; a=rsa-sha256; cv=none; b=WAbt2ozXTlKd3T17gf6hBParwsaaTJTxYFhFO/W2bzRlx82/9je2Y7Xa3vdYR1Ry4BfWrP hoNNBEwT4nZs9LTWhnFpcx1DUnoeKms2NOAYAJ9gmpTBB3dTAY7hewfP0td7j0JyK4w1H3 EBAReKLqwz3ekoHBuINhjxEADdtO46lr5vg3Dq9E+0K9Q+xs1gZ7inWOxkZJ5mLQrT4n3N RD+9qyTFzlHGih/GhYAtn97kDWS2ZNyjRj/M4tsFLwI1DVGKiyb2yeTifZlYCQ/wRMcjqe gIuJ+OsizH9Zou5HXDIxe8a1rkdMl0QtRlmGQ26eIy26eeV4Aa9+mq88hMeVAw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F315C108DC for ; Sun, 24 Dec 2023 12:13:06 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rHMP7-0003Xg-PY; Sun, 24 Dec 2023 06:12:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHMP4-0003XI-TQ for emacs-orgmode@gnu.org; Sun, 24 Dec 2023 06:12:18 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHMOv-0008My-Ct for emacs-orgmode@gnu.org; Sun, 24 Dec 2023 06:12:11 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0AC87240101 for ; Sun, 24 Dec 2023 12:12:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1703416325; bh=dg248wjV7q5GvRTRI+h1bKNsBtPKr1PCJOYdSDOMAFY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=SJEufc3m88AJ+oHIc6Vc74Q0H0KFmqCw+PtirINLOArXG5Vob/jdRviHLJsxakU8I olX07m5MJu15zKBcSfMsIggTQLGHnZ3R2c4m1S/vM2ro/Z1q7Qrz2TpD23pm4Mcf0D Qoa4Aud94Ovnd7xEfdW9+dlmRMPvvlj0voBr1NfJGjDupyJk1QJcOL2ldNJwlxwFGi FKtBfOANPK1SaufxAyS1WTrHWHkUWEvfpy9ta4ftiY0rOJPwUKeT9UipF/CmBSYK8r 9X5fG9zGI092jPB75A1xss2u5tcXAHL00c3e2QOei/1kkDnCJh3wWDQg014EalzAwO DsJt8YBFuXXUw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SydfC321sz6txD; Sun, 24 Dec 2023 12:12:03 +0100 (CET) From: Ihor Radchenko To: Morgan Smith Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org-agenda.el: Check agenda type earlier In-Reply-To: References: Date: Sun, 24 Dec 2023 11:15:16 +0000 Message-ID: <87v88nc0mz.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -4.70 X-Spam-Score: -4.70 X-Migadu-Queue-Id: F315C108DC X-TUID: LZJrPA2XHuxq Morgan Smith writes: > lisp/org-agenda.el (org-agenda-goto-date): Check agenda type earlier. > Also remove redundant error. > > When this function is run on a todo agenda the user is given the > undescriptive error "(wrong-type-argument listp "todo")" because we > attempt to parse the 'org-last-args text-property prematurely. With > this change users will get the much better error "Not allowed in > 'todo'-type agenda buffer or component". Thanks! Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=11e16e5f9 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at