From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id wBnVDyzsvGUyPQAAqHPOHw:P1 (envelope-from ) for ; Fri, 02 Feb 2024 14:20:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id wBnVDyzsvGUyPQAAqHPOHw (envelope-from ) for ; Fri, 02 Feb 2024 14:20:44 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Fq4qh3Su; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706880044; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hPSK6uaVB5C3NxIS3V8hJYfU1zfYbBJIp/tAqLpJKcY=; b=Zy6M1kU3a0gP0JrRCUUWfye09iy6tNSaRdUmR8IYfztbDmzhYClnqlaTeHAh/NXOzd5bWT +wLaYRyK0Rw1gDZt3ZULWV7LWieLVgZzX87fXGiIxohpAunNtQfjz5jIzd1+wW08hEIf19 RYvbH7k4lucruREQhl3Q/QcAxmXWxwkdR7KyosgD3uNoNmbqxKJhPlBqfuM6L4Z0+1VfCt zACtKDSJ2vH6BWAXdUJ0BRbH9A9qKj9+qRz3tCbTXQ2OXTBw6yTwYO3YtE0YhZtVDRVijt 9SFPlz1batm4kDZPTWNZHeSb9MvgcG5YNe8JdPy6Syp3c/n3CFtXLB6xmzym+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Fq4qh3Su; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706880044; a=rsa-sha256; cv=none; b=sgiqmyZh5DiRSjAMAINvjYhG/K78eAtMswZw9CjrOnw44ytqWKf9l1ICMSl6Cf0UQV52+Q YE5VX8SKr67/1KqbbTJnQ3LxntrT2glC9ICZAF2oRDTndKX3v/w+mqyyFBvFOakVL830Ow MWsdb69XIVNh70tEePfTYwAqJdptkCIQM6kkTEqgCrEDSHoCRZcQ8YCiCgQc9j4TLa0KU0 eU1J+bmiAZkp1gLoiHF/Qt0QDvO0dhyJb2yJbE1UFTmfcURN/1YrnxpWvskgnkFdEqPLXx m0jVhPnbFp2+NaqohQnprC76GPr8YSHGleRzVhX+a+20PmSEa7HeLXKQeu01CA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A1A2460E0E for ; Fri, 2 Feb 2024 14:20:43 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVtSe-0000My-AO; Fri, 02 Feb 2024 08:20:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVtSb-0000ME-81 for emacs-orgmode@gnu.org; Fri, 02 Feb 2024 08:20:01 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVtSY-0001td-Ug for emacs-orgmode@gnu.org; Fri, 02 Feb 2024 08:20:00 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 431A2240104 for ; Fri, 2 Feb 2024 14:19:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1706879996; bh=sS3V5rG4NBMORoh+kE7uKp6JxZb+95Yk/E2/QrnQ/e4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=Fq4qh3SubYYIEu0gXXHiYdg4zCzA9RspyoRC0TmOoIAtd6wnvqkCRQmkzB8thz+5o X2A0vRUbSRbCqo0j8iIW6UGIYReeIcuSAUbZ8451FfVoHynTGqXx2vL239G8IEqruX tURDwhK2T3Doo26qm5kYoB82TMpckj4y7vq78KJOWNE91OWb43pIP/aCxJ1g0Do5EQ Vn4H3q67nsQz7+5tpwngY98Rz3tQutmAUYffq1XgQuOib0F1iyhzSy3oSuyiC7bA7Y 9ij0HDaVzKsc9kMnleF+FCKUGhzObrXGKUqXpeDV6ylHP+qCMoHx+WbRQUWRyJipzd C4z5YjMw85GQw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TRGbH3VL7z6txP; Fri, 2 Feb 2024 14:19:55 +0100 (CET) From: Ihor Radchenko To: Rohit Patnaik Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] Newlines after links are fontified with the org-link face after an incremental search In-Reply-To: <38cddb14-78a9-424a-b83f-5b9f9217f8bc@app.fastmail.com> References: <38cddb14-78a9-424a-b83f-5b9f9217f8bc@app.fastmail.com> Date: Fri, 02 Feb 2024 13:23:25 +0000 Message-ID: <87v877xanm.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.88 X-Migadu-Scanner: mx13.migadu.com X-Spam-Score: -6.88 X-Migadu-Queue-Id: A1A2460E0E X-TUID: 5rrIDfTKXTFO "Rohit Patnaik" writes: > I've noticed a potential regression in the way that org-mode fontifies links in > the latest git main branch version of org-mode. When the user conducts an > incremental search that matches a link that runs to the end of the line, for > some reason the =org-link= face is extended to cover the newline as well. > > Detailed repro steps: > 1. Run =make repro= from the =main= branch > 2. Switch the scratch buffer to org-mode with =M-x org-mode= > 3. Add two lines > - The first line should be a link, for example: > [[https://www.google.com][Link]] > - The second line should be a blank line > 4. Place the point at the beginning of the first line > 5. Hit =C-s= to begin an incremental search and search for the link description > (i.e. =Link=) > 6. Hit =RET= to leave the search > 7. Note that the link underline now seems to extend past the end of the link > text Fixed, on main; for Emacs >=29. Will not be fixed for earlier Emacs versions. isearch + folding is very hard to make work reliably. We need to have ugly workarounds. And not only for isearch - a number of other parts of Emacs and third-party code exclusively support overlay folding. Considering that overlays are no longer performance bottleneck, switched back to using overlays for folding by default, except in Emacs <=28 where the overlays were slow. After Emacs 31 is released, folding via text properties will be removed. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at