Re: [BUG] Newlines after links are fontified with the org-link face after an incremental search

[Ihor Radchenko <yantar92@posteo.net>]

"Rohit Patnaik" <quanticle@quanticle.net> writes:

> I've noticed a potential regression in the way that org-mode fontifies links in
> the latest git main branch version of org-mode. When the user conducts an
> incremental search that matches a link that runs to the end of the line, for 
> some reason the =org-link= face is extended to cover the newline as well.
>
> Detailed repro steps:
> 1. Run =make repro= from the =main= branch
> 2. Switch the scratch buffer to org-mode with =M-x org-mode=
> 3. Add two lines
>    - The first line should be a link, for example:
>      [[https://www.google.com][Link]]
>    - The second line should be a blank line
> 4. Place the point at the beginning of the first line
> 5. Hit =C-s= to begin an incremental search and search for the link description
>    (i.e. =Link=)
> 6. Hit =RET= to leave the search
> 7. Note that the link underline now seems to extend past the end of the link
>    text

Fixed, on main; for Emacs >=29. Will not be fixed for earlier Emacs versions.

isearch + folding is very hard to make work reliably. We need to have
ugly workarounds. And not only for isearch - a number of other parts of
Emacs and third-party code exclusively support overlay folding.

Considering that overlays are no longer performance bottleneck, switched
back to using overlays for folding by default, except in Emacs <=28
where the overlays were slow. After Emacs 31 is released, folding via
text properties will be removed.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>