From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id eOxACsKqMmY2IgEAe85BDQ:P1 (envelope-from ) for ; Wed, 01 May 2024 22:49:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id eOxACsKqMmY2IgEAe85BDQ (envelope-from ) for ; Wed, 01 May 2024 22:49:06 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=U2jp5YdU; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714596546; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=x/G7Knik0MfLpT9MpVvLKOh0DFAy3Gi4ENc5F9zDja0=; b=GjymSrR9J7Qxcol25aKIqQSB4R8xXx/IcDilml+HrZFkg/RnMjXHp2aZT3IXB8eOyxebFx zn4acKubP/POvEPVuKjdHLxrFPRhoMpm5tRFJBokBTO3croVRBx+vtEyECIxHHmvSz8ZEm GadIdDQh87UwmdGAHQcm0jdF18jeB8381i8x4NkxByEA4CFEoYE0HeS37l5vgXfK8wvFHz EZ/iEFHI3phx1MvExp38KYN2zohXS3P7URET90y6Dy8bE3JOsOQf0xRBCddElFp+SL1S+o CRBAY/zqdJulqepAU/diUpHM5GynMkrHEoA2u4Go83CeN2Q1SRWlLEqYEiv8qA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=U2jp5YdU; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714596546; a=rsa-sha256; cv=none; b=WwuVIxtOa+F4dB8nsKdjUtgn8RjtVEvrSoi2rgh2ZevLyz7sfQAnMHzK1Ba59okW+huuil KQaXpWSQUZgfy+9Uv6GwRy6wmiGwAQn0UondVodG+ErWBt05U0hvNaK3da4ZMxFSR3sToQ kVdU+aakEuY/c+xaF46r0bz4nqWyaY/OeU1iyWa+AevaOrboIVTr7Eyyi060FqUcT8tTw8 VoRcpAihpyerjroaeQGU7K24IJOjpvMtw/vNFNkPtGUHeOucsg45ZcWQsj5xjKDRrcNjhH bVLr54PdXZeLzp6e63eO4lQrT+fto9j74KMP2P8Xwho59L5NzqynE19EWgqkXQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C64EC52847 for ; Wed, 1 May 2024 22:49:05 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2GsM-0004bJ-1f; Wed, 01 May 2024 16:48:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2GsE-0004Yi-Dt for emacs-orgmode@gnu.org; Wed, 01 May 2024 16:48:19 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2GsB-0001NM-Gx for emacs-orgmode@gnu.org; Wed, 01 May 2024 16:48:18 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 09A7A24002A for ; Wed, 1 May 2024 22:48:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1714596493; bh=lIDYXfi0taka36JOH8Ba0LS+aiT+7wSvkTG/ORu8cA4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=U2jp5YdUEAEe9+vJbCVUD+TAyGsJXFh+nN/Dd4ULlFQvmtW/bSDI7Mb4jvBXZCDqK smGr/yYHSVueopyGqInfg/DpLx8cFGN4Kn93pQRUYg9ItbknQdaSGFY0bShvN//13Z IP2HSMw7T4cTFlF/mZI31EihxDMNrNP+hqUZ3FjxlmeZanfmIia8Z4W7YvhgmIosuw l+WBltnWknCC5Nsr7AH8YIDUE5AK98kOuGWWXUdPztaBDxIfAsOhZ2OEEiw47ViW5S i93we3LOI/6ayO4L7ZqfhzqP/qNsiWXaRHFg9XiazlplL9ZRoo0KAr788ax6keZHZc xeuNjxsIrnbRA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VV8KR4w0Kz9rxB; Wed, 1 May 2024 22:48:11 +0200 (CEST) From: Ihor Radchenko To: Morgan Smith Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org.el: Obsolete `org-cached-entry-get' in favor of `org-entry-get' In-Reply-To: References: <87ttjkaywn.fsf@localhost> <877cgfywwg.fsf@localhost> <87y18tqsnz.fsf@localhost> Date: Wed, 01 May 2024 20:49:18 +0000 Message-ID: <87v83xqmup.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.84 X-Spam-Score: -6.84 X-Migadu-Queue-Id: C64EC52847 X-Migadu-Scanner: mx13.migadu.com X-TUID: IZLLwdohBuPO Morgan Smith writes: > The comment written just above `org-element-properties-map' says this: > > #+BEGIN_SRC elisp > ;; There is purposely no function like `org-element-properties' that > ;; returns a list of properties. Such function would tempt the users > ;; to (1) run it, creating a whole new list; (2) filter over that list > ;; - the process requiring a lot of extra consing, adding a load onto > ;; Emacs GC, memory used, and slowing things up as creating new lists > ;; is not free for CPU. > #+END_SRC > > This implies that the function `org-entry-properties' is just a bad > idea. Although giving it an argument for WHICH does make it better. That's my comment, so I cannot disagree. > It seems like it's only used in about 4 places in our codebase so if we > wanted to go further, we could potentially see more performance > enhancements if we obsolete this function as well. > > I haven't really looked into it much though so I apologize if my > analyses is wrong. Which it definitely could be. `org-entry-properties' is the only place where the logic to retrieve `org-special-properties' is implemented. So, we cannot just obsolete it. It should be a more extensive refactoring with factoring out the logic for retrieving special property values. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at