emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: Org uses obsolete `filter-buffer-substring-functions` variable
Date: Sun, 03 Nov 2024 07:48:57 +0000	[thread overview]
Message-ID: <87v7x4dafq.fsf@localhost> (raw)
In-Reply-To: <CADwFkmnpr_vjgsE0qAek-PXgEoDPZeYn06OCtpRBs6u6-KNjzQ@mail.gmail.com>

Stefan Kangas <stefankangas@gmail.com> writes:

> Org uses the obsolete variable `filter-buffer-substring-functions'.
> This variable is likely due for deletion in Emacs 31.1.
>
> Usually, compatibility code looks for the new way of doing things, and
> then prefers that.  But it seems like someone decided here to look for
> the old symbol instead, and prefer that.  Unless I'm missing something,
> it seems to me that the code for the _new_ variable has been hitherto
> unused.

We backported this change from b1d7e58520dc42a4eda902aa934a250fda6a04ca
Emacs commit.

> Could you please take a look to confirm that removing
> `filter-buffer-substring-functions' from Emacs won't break your code?
> I have attached a diff.

Seems good.
We also do not support Emacs 24 anymore, so the compatibility wrapper is
no longer necessary.

Feel free to either install the change on Emacs side or provide a patch
for me to install on Org side.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


      reply	other threads:[~2024-11-03  7:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-03  3:37 Org uses obsolete `filter-buffer-substring-functions` variable Stefan Kangas
2024-11-03  7:48 ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v7x4dafq.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).