From: Karthik Chikmagalur <karthikchikmagalur@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: "Björn Bidar" <bjorn.bidar@thaodan.de>, emacs-orgmode@gnu.org
Subject: Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]
Date: Thu, 26 Dec 2024 10:55:52 -0800 [thread overview]
Message-ID: <87v7v6mfyf.fsf@gmail.com> (raw)
In-Reply-To: <87y10jfk9c.fsf@localhost>
>> Ihor, what would be the best way of handling this? We can add a
>> `display-graphic-p' test when running the inline-images part of
>> org-startup, but then link previews that are not images won't be applied
>> either.
>
> 1. As a minimum, we can remove that message and do nothing on
> non-graphical displays. It will be consistent with earlier behavior.
I will remove that message from org-link-preview-file.
> 2. Maybe we can move the check about graphics to the specific preview
> functions.
What do you mean by 2? The check about graphics is already a part of
org-link-preview-file, which is a specific preview function.
Karthik
next prev parent reply other threads:[~2024-12-26 18:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 9:02 [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)] Björn Bidar
2024-12-03 23:42 ` Karthik Chikmagalur
2024-12-08 19:05 ` Björn Bidar
[not found] ` <6755ee4b.050a0220.72360.6df4SMTPIN_ADDED_BROKEN@mx.google.com>
2024-12-13 6:22 ` Karthik Chikmagalur
2024-12-13 19:36 ` Ihor Radchenko
2024-12-26 18:55 ` Karthik Chikmagalur [this message]
2024-12-27 17:19 ` Ihor Radchenko
2024-12-28 3:50 ` Karthik Chikmagalur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7v6mfyf.fsf@gmail.com \
--to=karthikchikmagalur@gmail.com \
--cc=bjorn.bidar@thaodan.de \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).