From: Bernt Hansen <bernt@norang.ca>
To: John Wiegley <jwiegley@gmail.com>
Cc: Tassilo Horn <tassilo@member.fsf.org>, emacs-orgmode@gnu.org
Subject: Re: A request: Moving away from ChangeLog
Date: Fri, 21 May 2010 11:39:42 -0400 [thread overview]
Message-ID: <87tyq12ri9.fsf@gollum.intra.norang.ca> (raw)
In-Reply-To: <32B3D851-51FA-43FA-8B14-594597FB42A1@gmail.com> (John Wiegley's message of "Fri\, 21 May 2010 11\:06\:36 -0400")
John Wiegley <jwiegley@gmail.com> writes:
> On May 21, 2010, at 9:47 AM, Tassilo Horn wrote:
>
>> I think it would be better if line 3+ would be exact ChangeLog entries
>> format-wise, so that you can still use emacs' ChangeLog facilities
>> (`add-change-log-entry'). I don't really want to write the changed file
>> and function names on my own, and adding them correctly is exactly what
>> that function does very well.
>
> This ends up looking rather ugly in the history, and I would hate to
> see VCS history bent merely to conform to tools usage.
>
> Rather, the history should be as clean and exact as possible. If
> elisp functions need to be written to convert ChangeLog entries to a
> suitable format, I can do that.
>
> Also, in magit if you press 'C' on any diff hunk, it auto-generates a
> properly formatted ChangeLog-style comment into the current commit
> log.
I also prefer descriptive and succinct commit messages.
It should be possible to automatically retrieve function information and
other items from the source based on hunk line information and the
source code in a tool that builds the Changelog.
I make most of my git commits (including org-mode) in vim which is
kicked off from raw command-line git. I normally make multiple changes
at once and then build separate commits by using git's editing hunk
features from 'git add -p'. I don't think that functionality is
available in magit yet.
Requiring an elisp-only solution for making commits isn't ideal -- the
tools should be as flexible as possible.
I have no issue with the maintainers rejecting patches and requesting
changes to the commit messages so that they can be applied to the
project but I wouldn't want to require the use of a specific tool to do
the job.
Regards,
Bernt
next prev parent reply other threads:[~2010-05-21 15:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 9:06 A request: Moving away from ChangeLog John Wiegley
2010-05-21 9:41 ` John Wiegley
2010-05-21 12:15 ` Carsten Dominik
2010-05-21 12:50 ` John Wiegley
2010-05-21 13:47 ` Tassilo Horn
2010-05-21 15:06 ` John Wiegley
2010-05-21 15:39 ` Bernt Hansen [this message]
2010-05-21 15:46 ` John Wiegley
2010-05-21 16:01 ` Bernt Hansen
2010-05-21 16:32 ` Eric Schulte
2010-05-21 15:53 ` Carsten Dominik
2010-05-21 15:58 ` John Wiegley
2010-05-21 14:32 ` Carsten Dominik
2010-05-21 15:08 ` John Wiegley
2010-05-21 15:33 ` John Wiegley
2010-05-21 13:01 ` Ben Finney
2010-05-21 14:21 ` Carsten Dominik
2010-05-21 21:10 ` Christian Egli
2010-05-21 21:17 ` Julien Danjou
2010-06-01 14:58 ` Carsten Dominik
2010-06-02 7:44 ` Christian Egli
2010-06-02 9:32 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tyq12ri9.fsf@gollum.intra.norang.ca \
--to=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
--cc=jwiegley@gmail.com \
--cc=tassilo@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).